New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 918178 link

Starred by 2 users
Status: Started
Owner:
chanli@chromium.org
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit]ValueError: time data '2018-W50-7' does not match format '%Y-W%W-%w'

Project Member Reported by chanli@chromium.org, Dec 28 
Root cause is because of discrepancies between ISO time and gregorian time.


Stack trace sample

ValueError: time data '2018-W50-7' does not match format '%Y-W%W-%w'
at _strptime (/base/alloc/tmpfs/dynamic_runtimes/python27g/7e468a4e2dbc991a/python27/python27_dist/lib/python2.7/_strptime.py:332)
at _ConvertISOWeekStringToUTCDatetime (/base/data/home/apps/s~findit-for-me/flake-detection-backend:19725-f99e598.414806298265931470/libs/time_util.py:50)
at ConvertISOWeekToUTCDatetime (/base/data/home/apps/s~findit-for-me/flake-detection-backend:19725-f99e598.414806298265931470/libs/time_util.py:60)
at Report (/base/data/home/apps/s~findit-for-me/flake-detection-backend:19725-f99e598.414806298265931470/services/flake_reporting/component.py:87)
at HandleGet (/base/data/home/apps/s~findit-for-me/flake-detection-backend:19725-f99e598.414806298265931470/handlers/flake/reporting/generate_report.py:16)
at _Handle (/base/data/home/apps/s~findit-for-me/flake-detection-backend:19725-f99e598.414806298265931470/gae_libs/handlers/base_handler.py:224)
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a282544a2e482f18697efa795c5667c691248fd1

commit a282544a2e482f18697efa795c5667c691248fd1
Author: Chan <chanli@chromium.org>
Date: Fri Jan 11 23:16:28 2019

[Findit] Data model change for flake report

To save the hassle of converting report time back and forth, use the start date of previous week and luci_project as key to flake report instead of iso week info.

Bug: 918178

Change-Id: I5c92cc549307d9e27effb0bf3061bcececcface6
Reviewed-on: https://chromium-review.googlesource.com/c/1392372
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19949}
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/handlers/flake/reporting/flake_report.py
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/services/flake_reporting/test/component_test.py
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/waterfall/test/wf_testcase.py
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/services/flake_reporting/component.py
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/handlers/flake/reporting/component_report.py
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/libs/time_util.py
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/model/flake/reporting/report.py
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/services/constants.py
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/templates/flake/report/flake_report.html
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/index.yaml
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/handlers/flake/reporting/test/component_report_test.py
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/model/flake/reporting/test/report_test.py
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/handlers/flake/reporting/test/flake_report_test.py
[modify] https://crrev.com/a282544a2e482f18697efa795c5667c691248fd1/appengine/findit/libs/test/time_util_test.py
►

Sign in to add a comment