New issue
Advanced search Search tips

Issue 918144 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 3
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 889864



Sign in to add a comment

Prepare FontUniqueName Table for reuse on Windows

Project Member Reported by drott@chromium.org, Dec 28

Issue description

We can reuse the FontUniqueNameTable proto structure on Windows for font unique name matching and building a font unique name lookup table there. 


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dae2e36178c87be5dda28c84412fe0eae1df64ab

commit dae2e36178c87be5dda28c84412fe0eae1df64ab
Author: Dominik Röttsches <drott@chromium.org>
Date: Thu Jan 03 08:23:13 2019

Use binary search for font matching, allow multiple names per font

Change the FontUniqueNameTable proto to allow associating font unique
names of multiple locales with the same font file. We do not need to
distinguish them in storage, as the information about which type of font
name was matched will not be needed later. Sort the name lookup table
upfront, so that later searches can be more efficient and employ binary
search.

As a preparation to using this for the Windows font unique name matching
implementation, generalize the proto field which is used for storing the
Android build fingerprint when persisting this protobuf.

Bug:  918144 
Change-Id: Ib3fe8840564429a68c6444dd2e9760a21848b7ca
Reviewed-on: https://chromium-review.googlesource.com/c/1392096
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619601}
[modify] https://crrev.com/dae2e36178c87be5dda28c84412fe0eae1df64ab/content/browser/font_unique_name_lookup/font_unique_name_lookup.cc
[modify] https://crrev.com/dae2e36178c87be5dda28c84412fe0eae1df64ab/content/browser/font_unique_name_lookup/font_unique_name_lookup.h
[modify] https://crrev.com/dae2e36178c87be5dda28c84412fe0eae1df64ab/third_party/blink/common/font_unique_name_lookup/font_table_matcher.cc
[modify] https://crrev.com/dae2e36178c87be5dda28c84412fe0eae1df64ab/third_party/blink/common/font_unique_name_lookup/font_table_matcher_unittest.cc
[modify] https://crrev.com/dae2e36178c87be5dda28c84412fe0eae1df64ab/third_party/blink/public/common/font_unique_name_lookup/font_unique_name_table.proto

Status: Fixed (was: Untriaged)

Sign in to add a comment