Support out of tree Ozone platform builds
Reported by
paullo...@gmail.com,
Dec 28
|
|
Issue descriptionUserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0 Steps to reproduce the problem: Try to integrate new ozone platform. You have to patch //ui/ozone/ozone_extra.gni to include it in the build. What is the expected behavior? It would be good to build out of tree Ozone platform without any patching. What went wrong? I have to maintatin patch system in my ozone platform source tree. Did this work before? No Chrome version: <Copy from: 'about:version'> Channel: canary OS Version: Flash Version: This can be sloved by introducing additional build argument pointing to //ui/ozone/ozone_extra.gni by default. In my source tree I can then override default value in .gn file.
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/622d466d1a6774a0077a82266454bcdc8337bd02 commit 622d466d1a6774a0077a82266454bcdc8337bd02 Author: Pavel Golikov <paullo612@ya.ru> Date: Thu Jan 03 17:41:53 2019 [Ozone] Add out of tree platforms build support Introduced ozone_extra_path build argument. It points to additional platforms file to include while building ozone platforms. It points to //ui/ozone/ozone_extra.gni by default for backward compatibility. Bug: 918118 Change-Id: If6db25b3693f319955fdec54d9f91d47422a6e38 Reviewed-on: https://chromium-review.googlesource.com/c/1391687 Reviewed-by: Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#619679} [modify] https://crrev.com/622d466d1a6774a0077a82266454bcdc8337bd02/ui/ozone/BUILD.gn [modify] https://crrev.com/622d466d1a6774a0077a82266454bcdc8337bd02/ui/ozone/common/BUILD.gn [modify] https://crrev.com/622d466d1a6774a0077a82266454bcdc8337bd02/ui/ozone/ozone.gni |
|
►
Sign in to add a comment |
|
Comment 1 by swarnasree.mukkala@chromium.org
, Dec 31