New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 918046: Need VPython Wheel for grpc-google-iam-admin-v1

Reported by mbinette@google.com, Dec 27 Project Member

Issue description

Link to PyPI: https://pypi.org/project/grpc-google-iam-admin-v1
Wheel Name: grpc-google-iam-admin-v1
Version: 0.10.0
Platform(s) Required: Linux

Needed for celab tests (some of our protos have references to protos from that package).
 

Comment 1 by qyears...@chromium.org, Jan 8

Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by qyears...@chromium.org, Jan 8

Status: Started (was: Assigned)
Started: https://chromium-review.googlesource.com/c/infra/infra/+/1401188

Comment 3 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5dceb532e7ec69c96c3abbacb1f1fc5b225deaa2

commit 5dceb532e7ec69c96c3abbacb1f1fc5b225deaa2
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Wed Jan 09 00:26:57 2019

Add grpc-google-iam-admin-v1 wheel

Bug:  918046 
Change-Id: Id1f6ea03654a70443f609752d40e1c8552b43791
Reviewed-on: https://chromium-review.googlesource.com/c/1401188
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19843}
[modify] https://crrev.com/5dceb532e7ec69c96c3abbacb1f1fc5b225deaa2/infra/tools/dockerbuild/wheel.py
[modify] https://crrev.com/5dceb532e7ec69c96c3abbacb1f1fc5b225deaa2/infra/tools/dockerbuild/wheels.md

Comment 4 by mbinette@google.com, Jan 9

Thanks Quinten! I was able to to pull in the new package. It looks like it also refers to this one which wasn't in the setup file: https://pypi.org/project/grpc-google-iam-v1

(in google/iam/admin/v1/iam_pb2.py -- from google.iam.v1 import [...])

Comment 5 by qyearsley@google.com, Jan 9

Ah, yes, we need to make sure all transitive dependencies are there. I'll add grpc-google-iam-v1 as well.

Comment 6 by bugdroid1@chromium.org, Jan 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e6e1c8e2762a61f3e022067d1263bfa1f3736c08

commit e6e1c8e2762a61f3e022067d1263bfa1f3736c08
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Wed Jan 09 18:56:19 2019

Add wheel grpc-google-iam-v1-0.11.4

This is a dependency of grpc-google-iam-admin-v1, which was added
in https://chromium-review.googlesource.com/c/1401188.

Bug:  918046 
Change-Id: I49589fc1bccba3e2169459cb01be9173f2564a11
Reviewed-on: https://chromium-review.googlesource.com/c/1403219
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19867}
[modify] https://crrev.com/e6e1c8e2762a61f3e022067d1263bfa1f3736c08/infra/tools/dockerbuild/wheel.py
[modify] https://crrev.com/e6e1c8e2762a61f3e022067d1263bfa1f3736c08/infra/tools/dockerbuild/wheels.md

Comment 7 by qyears...@chromium.org, Jan 9

Status: Fixed (was: Started)
Should work now after adding an entry for grpc-google-iam-v1 in the vpython file, please reopen if it still doesn't work as expected.

Comment 8 by mbinette@google.com, Jan 10

Status: Verified (was: Fixed)

Sign in to add a comment