Issue metadata
Sign in to add a comment
|
Font smoothing/AA applied to top chrome fonts even if disabled in system settings
Reported by
bau...@gmail.com,
Dec 27
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.28 Safari/537.36 Steps to reproduce the problem: 1. update to Version 72.0.3626.28 (Build officiel) beta (64 bits) 2. open chrome (without clear type and smooth on system windows) 3. What is the expected behavior? same as before, respect system setting, and not use blurred font. USE PIXEL FONT for lcd screen What went wrong? text blurred Did this work before? Yes 71 beta Chrome version: 72.0.3626.28 Channel: beta OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: instead of improving visibility, sharpness, Google makes all its applications / websites blurry for those who use their screen in native resolution without ZOOM. Think of users who have good eyes, and do not need a gray smoothing. It's like a text that we would have rubbed with a blotter. readability mediocre, it seems to be spent on IE11
,
Dec 28
,
Dec 28
Tried testing the issue on reported chrome version #72.0.3626.28 on Windows 7 by following below steps. Steps: ===== 1.Launched chrome. 2.Navigated to "chrome://settings". 3.Observed that the fonts are not blurry in the title tab. 4.Right clicked for the menu, did not observe any blurry text there too. Note: Tried above with new tab page, observed the same behavior. Attached screencast for reference. @reporter: Could you please review attached screencast and let us know if anything is being missed here. Thanks.!
,
Dec 28
difficult to see on the high compression screencast. it will seem that you are using system font smoothing and maybe cleartype? Please disable windows smooth fonts (https://www.sevenforums.com/tutorials/127337-smooth-edges-screen-fonts-enable-disable.html) and windows cleartype. In previous version 71 beta, the text in tab and right clic are not smooth, black text. Now text is grey because use smooth/blur. See screenshot (PNG lossless). I must resintall previous version or restore backup, because now, Chrome remove old Chrome Application folder to share result with previous version.
,
Dec 28
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 28
reinstalled Chrome 71. text in tab, omnibox, right clic.. are clear, no smoothing/blur. (see chrome71.png and zoom in image without effect. Or see zoom71: text in tab and omnibox are clear, no smooth/blur effect; only icon to close and magnifying glass search icon are smooth/blur effect
,
Dec 31
Tried testing the issue on the reported chrome version #72.0.3626.28 using Windows 7 by following below steps. Steps: ====== 1.Navigated to -"https://www.sevenforums.com/tutorials/127337-smooth-edges-screen-fonts-enable-disable.html". 2.Using the method 2 mentioned in above URL, disabled windows smooth fonts. 3.Launched chrome. 4.Navigated to "chrome://settings". 5.Observed that the magnifying glass and tab close button are not blurred. 6.The right-click menu is also not blurred. Attached screencast and screenshot for reference. @reporter: Could you please review attached screencast and screenshot, let us know if anything is being missed from our end. Thanks.!
,
Dec 31
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 2
Tried testing the issue on chrome version #71.0.3578.98 and reported chrome version #72.0.3626.28 by following steps as per comment#0 and comment#5. Unable to observe any noticeable blur effects on magnifying glass, tab close button and text on tab strip. Attaching screenshots for reference. Requesting someone from the respective dev team to look into the issue and help us in further triaging. Thanks.!
,
Jan 2
The word "blur" is misleading here. The screenshots in comment 11 demonstrate that Chrome 72 is applying AA to the text in the omnibox and tabstrip where Chrome 71 was not. I'm not sure who owns the font rendering for top chrome. +CC behdad@ who might know how to triage or diagnose this more
,
Jan 3
Able to reproduce the issue on reported chrome version #72.0.3626.28 and latest chrome #73.0.3659.0 by following steps as per comment#0 and comment#5 using Windows 7. The following is the bisect information. Note: Tried testing the issue on Mac OS and Linux but unable to find the considerable difference between two fonts. Bisect information: ==================== Good Build: 72.0.3608.0 Bad Build: 72.0.3610.0 Unable to provide bisect information as builds were not invoking while running chromium bisect. Hence providing manual bisect information. CHANGE LOG: https://chromium.googlesource.com/chromium/src/+log/72.0.3608.0..72.0.3610.0?pretty=fuller&n=10000 Suspect On:https://skia.googlesource.com/skia.git/+log/49e1239f94fe..fd1fd279a353 Reviewed On: https://skia-review.googlesource.com/c/skia/+/170352 @Mike Reed: Please help us in re-assigning the issue if it is not related to your change. Adding ReleaseBlock stable as it seems to be a recent regression, please feel free to remove it if not applicable. Thanks.!
,
Jan 8
Friendly ping! Could you please provide any update on this issue as it has been marked as a stable blocker. Thank You!
,
Jan 14
Gentle ping! Could you please provide any update on this issue as it has been marked as a stable blocker. Thank You!
,
Jan 14
Hi, not solved on Version 72.0.3626.53
,
Jan 14
chromers, where/how are these settings surfaced? Where in blink/chrome should they be inspected when building textblobs?
,
Jan 14
Looks like an issue in PaintFlags::ToSkFont() [1]: we only set Edging if AA is enabled, assuming the default Edging is kAlias -- but https://skia-review.googlesource.com/c/skia/+/170352 changed the default to kAntiAlias => fonts are never aliased. I think this will be fixed (inadvertently) in https://chromium-review.googlesource.com/c/chromium/src/+/1408310 [1] https://cs.chromium.org/chromium/src/cc/paint/paint_flags.cc?rcl=b9544bb61fc022eeff8d259231b64900a2398c33&l=156
,
Jan 14
[bulk update] Just a heads up, M72 stable is about 2 weeks away. This issue is marked as RB-Stable. Please take a look.
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0c9012b3cef2a92b3cf9ce94f44d7d8dd9d4128 commit e0c9012b3cef2a92b3cf9ce94f44d7d8dd9d4128 Author: Florin Malita <fmalita@chromium.org> Date: Mon Jan 14 19:42:35 2019 Fix aliased Edging in PaintFlags::ToSkFont() PaintFlags::ToSkFont() assumes the default SkFont Edging is kAliased, but that is no longer the case. Set kAliased Edging explicitly when AA is disabled. Bug: 918030 Change-Id: Ia8b38a1190a70eff109d4f9c9ddf50bdcb3b3f56 Reviewed-on: https://chromium-review.googlesource.com/c/1409343 Reviewed-by: enne <enne@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#622553} [modify] https://crrev.com/e0c9012b3cef2a92b3cf9ce94f44d7d8dd9d4128/cc/paint/paint_flags.cc [modify] https://crrev.com/e0c9012b3cef2a92b3cf9ce94f44d7d8dd9d4128/ui/gfx/render_text_unittest.cc
,
Jan 14
The fix in c#20 is trivial, obvious and verified in a unit test. Requesting an M72 merge.
,
Jan 15
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 15
Thanks fmalita@ - have you verified this in canary today?
,
Jan 15
I'm actually having trouble locating a Windows machine to test at the moment... swarnasree.mukkala@ do you mind verifying a recent canary build?
,
Jan 15
+pucchakayala@ can you please verify this as well?
,
Jan 16
Font smoothing/ AA has not been applied to top chrome [to the text in the omnibox and tabstrip] on latest canary build # 73.0.3672.0 Win10/64 bit. Please find the screenshot showing Canary v/s Beta [72.0.3626.53].
,
Jan 16
Used Option 3 in the following article to disable the Smooth edges of the fonts https://www.sevenforums.com/tutorials/127337-smooth-edges-screen-fonts-enable-disable.html fmalita@, could you please merge the fix in to the M72 branch if everything looks correct in # 26 verification ?
,
Jan 16
Thanks pucchakayala@, everything looks good in c#26. I'll merge first thing in the morning.
,
Jan 16
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69f2b47ba293618dd773e205cb1cc79607504697 commit 69f2b47ba293618dd773e205cb1cc79607504697 Author: Florin Malita <fmalita@chromium.org> Date: Wed Jan 16 01:14:02 2019 Fix aliased Edging in PaintFlags::ToSkFont() PaintFlags::ToSkFont() assumes the default SkFont Edging is kAliased, but that is no longer the case. Set kAliased Edging explicitly when AA is disabled. Bug: 918030 Change-Id: Ia8b38a1190a70eff109d4f9c9ddf50bdcb3b3f56 Reviewed-on: https://chromium-review.googlesource.com/c/1409343 Reviewed-by: enne <enne@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#622553}(cherry picked from commit e0c9012b3cef2a92b3cf9ce94f44d7d8dd9d4128) Reviewed-on: https://chromium-review.googlesource.com/c/1414010 Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#707} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/69f2b47ba293618dd773e205cb1cc79607504697/cc/paint/paint_flags.cc [modify] https://crrev.com/69f2b47ba293618dd773e205cb1cc79607504697/ui/gfx/render_text_unittest.cc
,
Jan 16
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69f2b47ba293618dd773e205cb1cc79607504697 Commit: 69f2b47ba293618dd773e205cb1cc79607504697 Author: fmalita@chromium.org Commiter: fmalita@chromium.org Date: 2019-01-16 01:14:02 +0000 UTC Fix aliased Edging in PaintFlags::ToSkFont() PaintFlags::ToSkFont() assumes the default SkFont Edging is kAliased, but that is no longer the case. Set kAliased Edging explicitly when AA is disabled. Bug: 918030 Change-Id: Ia8b38a1190a70eff109d4f9c9ddf50bdcb3b3f56 Reviewed-on: https://chromium-review.googlesource.com/c/1409343 Reviewed-by: enne <enne@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#622553}(cherry picked from commit e0c9012b3cef2a92b3cf9ce94f44d7d8dd9d4128) Reviewed-on: https://chromium-review.googlesource.com/c/1414010 Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#707} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 16
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bau...@gmail.com
, Dec 2731.8 KB
31.8 KB View Download