New issue
Advanced search Search tips

Issue 918029 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Make D3D11VideoDecoder provide SupportedVideoDecoderConfig

Project Member Reported by liber...@chromium.org, Dec 27

Issue description

currently, D3D11VideoDecoder relies implicitly on the dxva VDA supported configs.  this doesn't properly convey support for encrypted content, or any other limitations of the d3d11 decoder.

D3D11VideoDecoder should provide its own correct supported profiles to the renderer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6649db74c4263719b1ab510ee8a3c1ff0b625ff4

commit 6649db74c4263719b1ab510ee8a3c1ff0b625ff4
Author: liberato@chromium.org <liberato@chromium.org>
Date: Thu Jan 03 20:05:41 2019

Add media::SupportedVideoDecoderConfig

This CL adds SupportedVideoDecoderConfig to match the mojom struct.
It also adds a struct traits for them, and converts the existing
mojo code to use the media:: rather than the mojom:: version.

This will make it easier for {D3D11, MediaCodec}VideoDecoder to
return their media::SupportedVideoDecoderConfigs, since they cannot
use mojo directly.

Bug: 918029
Change-Id: Id0403ccadaa1b3fbbb310f01fd9b3a7bebc92ba7
Reviewed-on: https://chromium-review.googlesource.com/c/1392350
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619729}
[modify] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/content/renderer/media/gpu/gpu_video_accelerator_factories_impl.cc
[modify] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/content/renderer/media/gpu/gpu_video_accelerator_factories_impl.h
[add] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/media/mojo/interfaces/supported_video_decoder_config_struct_traits.cc
[add] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/media/mojo/interfaces/supported_video_decoder_config_struct_traits.h
[modify] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/media/mojo/interfaces/video_decoder.typemap
[modify] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/media/mojo/services/gpu_mojo_media_client.cc
[modify] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/media/mojo/services/gpu_mojo_media_client.h
[modify] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/media/mojo/services/mojo_media_client.cc
[modify] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/media/mojo/services/mojo_media_client.h
[modify] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/media/video/BUILD.gn
[add] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/media/video/supported_video_decoder_config.cc
[add] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/media/video/supported_video_decoder_config.h
[add] https://crrev.com/6649db74c4263719b1ab510ee8a3c1ff0b625ff4/media/video/supported_video_decoder_config_unittest.cc

Status: Available (was: Started)
This issue has been marked as started, but has no owner. Making available.

Sign in to add a comment