New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 918009 link

Starred by 1 user
Status: Fixed
Owner:
caseq@chromium.org
Closed: Dec 28
Cc:
█ lushnikov@chromium.org
dgozman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: support file: schema when intercepting requests in network service mode

Project Member Reported by caseq@chromium.org, Dec 27 
Old interceptor supports file schema, so the network service one should too -- puppeteer clients depend on this.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72bd2ef71b40e3f9f467ec38968110a48d9ea270

commit 72bd2ef71b40e3f9f467ec38968110a48d9ea270
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Dec 27 23:30:13 2018

DevTools: support interception for file: schema

BUG= 918009 

Change-Id: I31ffbd2b1fb3bc56afdbdf2113afdde839b7bbc0
Reviewed-on: https://chromium-review.googlesource.com/c/1391353
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619087}
[modify] https://crrev.com/72bd2ef71b40e3f9f467ec38968110a48d9ea270/content/browser/devtools/devtools_instrumentation.cc
[modify] https://crrev.com/72bd2ef71b40e3f9f467ec38968110a48d9ea270/content/browser/devtools/devtools_instrumentation.h
[modify] https://crrev.com/72bd2ef71b40e3f9f467ec38968110a48d9ea270/content/browser/devtools/devtools_url_loader_interceptor.cc
[modify] https://crrev.com/72bd2ef71b40e3f9f467ec38968110a48d9ea270/content/browser/devtools/devtools_url_loader_interceptor.h
[modify] https://crrev.com/72bd2ef71b40e3f9f467ec38968110a48d9ea270/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/72bd2ef71b40e3f9f467ec38968110a48d9ea270/third_party/blink/web_tests/inspector-protocol/network/interception-file-url-expected.txt
[modify] https://crrev.com/72bd2ef71b40e3f9f467ec38968110a48d9ea270/third_party/blink/web_tests/inspector-protocol/network/interception-file-url.js
[add] https://crrev.com/72bd2ef71b40e3f9f467ec38968110a48d9ea270/third_party/blink/web_tests/inspector-protocol/network/resources/simple.js

Comment 2 by caseq@chromium.org, Dec 28

Status: Fixed (was: Assigned)
Andrey, could you please check if it works with puppeteer?
►

Sign in to add a comment