New issue
Advanced search Search tips

Issue 917978 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task



Sign in to add a comment

Make general support of whitelisting the events to be dispatched during pause

Project Member Reported by yukishiino@chromium.org, Dec 27

Issue description

For the event dispatch during pause, the current way of whitelisting is a bit ad-hoc.  Make it a smart and well-described way.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9e62670337728d794ff24e36520af98b13d5ab9

commit c9e62670337728d794ff24e36520af98b13d5ab9
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Fri Dec 28 05:34:15 2018

v8binding: Refactor event dispatch while execution context is paused

Introduce a general way to run event listeners while a related
execution context is paused.

Introduce Event::ShouldDispatchEvenWhenExecutionContextIsPaused
and let each event subclass control the priority over pause.

Change-Id: I2b3cdc04c5e799084a6c062d3a106b858a8ccd52
Bug:  917978 
Reviewed-on: https://chromium-review.googlesource.com/c/1390875
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619122}
[modify] https://crrev.com/c9e62670337728d794ff24e36520af98b13d5ab9/third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
[modify] https://crrev.com/c9e62670337728d794ff24e36520af98b13d5ab9/third_party/blink/renderer/bindings/core/v8/js_event_listener.cc
[modify] https://crrev.com/c9e62670337728d794ff24e36520af98b13d5ab9/third_party/blink/renderer/core/css/media_query_list_event.h
[modify] https://crrev.com/c9e62670337728d794ff24e36520af98b13d5ab9/third_party/blink/renderer/core/dom/events/event.h
[modify] https://crrev.com/c9e62670337728d794ff24e36520af98b13d5ab9/third_party/blink/renderer/core/events/BUILD.gn
[add] https://crrev.com/c9e62670337728d794ff24e36520af98b13d5ab9/third_party/blink/renderer/core/events/after_print_event.h
[add] https://crrev.com/c9e62670337728d794ff24e36520af98b13d5ab9/third_party/blink/renderer/core/events/before_print_event.h
[modify] https://crrev.com/c9e62670337728d794ff24e36520af98b13d5ab9/third_party/blink/renderer/core/events/before_unload_event.h
[modify] https://crrev.com/c9e62670337728d794ff24e36520af98b13d5ab9/third_party/blink/renderer/core/frame/web_local_frame_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment