chaps: Refactor the session_impl.cc |
||||||||
Issue descriptionNotes for some working items, 1. Using template for RSAEncrypt/RSADecrypt/RSASign/RSAVerify See https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1391045/2/chaps/session_impl.cc#1307 2. (ECC done, RSA not yet) break CreateRSAKeyFromObject() to CreateRSAKeyFromPublicKey() and CreateRSAKeyFromPrivateKey(). See https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1391044/2/chaps/session_impl.cc#1204 3. Move CreateRSAKeyFromObject() series function to Object class. 4. (Done) Isolate IsXXX series function. See * https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1391041/2/chaps/session_impl.cc#692 * https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1391041/2/chaps/session_impl.cc#767 ⛆ |
|
|
,
Dec 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e0bae29dc4ca5e8bcdcc2baa62df9ed62b6a7045 commit e0bae29dc4ca5e8bcdcc2baa62df9ed62b6a7045 Author: Meng-Huan Yu <menghuan@chromium.org> Date: Fri Dec 28 21:01:28 2018 chaps: Rename CreateKeyFromObject to CreateRSAKeyFromObject Since we have RSA and ECC in the future. Rename it to a proper name. BUG=chromium:917955 TEST=passed unittest (expect no behavior change) Change-Id: I312f5a9962490fd8a20a78559709ecf94f2f4aac Reviewed-on: https://chromium-review.googlesource.com/1391043 Commit-Ready: Meng-Huan Yu <menghuan@chromium.org> Tested-by: Meng-Huan Yu <menghuan@chromium.org> Reviewed-by: Meng-Huan Yu <menghuan@chromium.org> Reviewed-by: Wei-Cheng Xiao <garryxiao@chromium.org> [modify] https://crrev.com/e0bae29dc4ca5e8bcdcc2baa62df9ed62b6a7045/chaps/session_impl.cc [modify] https://crrev.com/e0bae29dc4ca5e8bcdcc2baa62df9ed62b6a7045/chaps/session_impl.h
,
Jan 2
,
Jan 4
,
Jan 4
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/043a45f374d48df690105e03fd73aedf9d403d6a commit 043a45f374d48df690105e03fd73aedf9d403d6a Author: Meng-Huan Yu <menghuan@chromium.org> Date: Fri Jan 04 23:30:53 2019 chaps: Return crypto::ScopedRSA instead of RSA* in CreateRSAKeyFromObject crypto::ScopedRSA is a smart pointer wrapped version of RSA*. BUG=chromium:917955 TEST=passed unittest (expect no behavior change at API view) TEST=p11_replay --generate_delete Change-Id: Ia9fe16cf0b24e03dce58c6d3b0b13e87c7d342dc Reviewed-on: https://chromium-review.googlesource.com/1391044 Commit-Ready: Meng-Huan Yu <menghuan@chromium.org> Tested-by: Meng-Huan Yu <menghuan@chromium.org> Reviewed-by: Wei-Cheng Xiao <garryxiao@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/043a45f374d48df690105e03fd73aedf9d403d6a/chaps/session_impl.cc [modify] https://crrev.com/043a45f374d48df690105e03fd73aedf9d403d6a/chaps/session_impl.h
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c3c2db4bf8a77079bfdda916f69185d2c4bd8769 commit c3c2db4bf8a77079bfdda916f69185d2c4bd8769 Author: Meng-Huan Yu <menghuan@chromium.org> Date: Wed Jan 09 19:55:36 2019 chaps: Add comments and small change for operation related functions BUG=chromium:917955 TEST=passed unittest (expect no behavior change) Change-Id: Iad459eff093a297f721b860ff319c65e2de3abe9 Reviewed-on: https://chromium-review.googlesource.com/1391041 Commit-Ready: Meng-Huan Yu <menghuan@chromium.org> Tested-by: Meng-Huan Yu <menghuan@chromium.org> Reviewed-by: Louis Collard <louiscollard@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/c3c2db4bf8a77079bfdda916f69185d2c4bd8769/chaps/session_impl.cc [modify] https://crrev.com/c3c2db4bf8a77079bfdda916f69185d2c4bd8769/chaps/session_impl.h
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f288330c5691d056e5970e62a9488900e5060ff1 commit f288330c5691d056e5970e62a9488900e5060ff1 Author: Meng-Huan Yu <menghuan@chromium.org> Date: Wed Jan 09 19:55:36 2019 chaps: Run clang-format on session_impl.cc/.h Coding style fixing by clang-format. BUG=chromium:917955 TEST=PreCQ Change-Id: I6d36413f533b45a7bbf30c40aced5faada666583 Reviewed-on: https://chromium-review.googlesource.com/1391045 Commit-Ready: Meng-Huan Yu <menghuan@chromium.org> Tested-by: Meng-Huan Yu <menghuan@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/f288330c5691d056e5970e62a9488900e5060ff1/chaps/session_impl.cc [modify] https://crrev.com/f288330c5691d056e5970e62a9488900e5060ff1/chaps/session_impl.h
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/17f0bc95c1549355d46dd7b0a066ca261e763842 commit 17f0bc95c1549355d46dd7b0a066ca261e763842 Author: Meng-Huan Yu <menghuan@chromium.org> Date: Wed Jan 09 19:55:35 2019 chaps: Refactor Is* series helper in session_impl.cc * Change IsValidMechanism to IsMechanismValidForOperation * Use a map to put all mechanism config together and rewrite * IsHMAC * IsPaddingEnabled * IsRSA * IsMechanismValidForOperation * IsValidKeyType * Move above functions to unamed namespace. BUG=chromium:917955 TEST=passed unittest Change-Id: I73b2a37cf78eb3571d4f19c7a7e6f40e31f20fa1 Reviewed-on: https://chromium-review.googlesource.com/1391615 Commit-Ready: Meng-Huan Yu <menghuan@chromium.org> Tested-by: Meng-Huan Yu <menghuan@chromium.org> Reviewed-by: Meng-Huan Yu <menghuan@chromium.org> [modify] https://crrev.com/17f0bc95c1549355d46dd7b0a066ca261e763842/chaps/session_impl.cc [modify] https://crrev.com/17f0bc95c1549355d46dd7b0a066ca261e763842/chaps/session_impl.h
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d48ea761337708a1d3cd36f1b734b304960d2afb commit d48ea761337708a1d3cd36f1b734b304960d2afb Author: Meng-Huan Yu <menghuan@chromium.org> Date: Wed Jan 09 19:55:35 2019 chaps: Move helper function from member function to unamed namespace * Move the following functions to unamed namespace. * ConvertFromBIGNUM * CreateRSAKeyFromObject * GetOpenSSLCipher * GetOpenSSLDigest * Move some local constant to unamed namespace. BUG=chromium:917955 TEST=passed unit test Change-Id: Idd5f043fcf8ce49ade7baa69fb85295857e3d450 Reviewed-on: https://chromium-review.googlesource.com/1391616 Commit-Ready: Meng-Huan Yu <menghuan@chromium.org> Tested-by: Meng-Huan Yu <menghuan@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/d48ea761337708a1d3cd36f1b734b304960d2afb/chaps/session_impl.cc [modify] https://crrev.com/d48ea761337708a1d3cd36f1b734b304960d2afb/chaps/session_impl.h
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f46c7831ed20839665cccf1fae95df7d2412a049 commit f46c7831ed20839665cccf1fae95df7d2412a049 Author: Meng-Huan Yu <menghuan@chromium.org> Date: Wed Jan 09 19:55:36 2019 chaps: Change all NULL to nullptr in session_impl.cc BUG=chromium:917955 TEST=PreCQ Change-Id: I6658d767dda7c35fb46b971ced2d01b4500d3c7a Reviewed-on: https://chromium-review.googlesource.com/1392128 Commit-Ready: Meng-Huan Yu <menghuan@chromium.org> Tested-by: Meng-Huan Yu <menghuan@chromium.org> Reviewed-by: Wei-Cheng Xiao <garryxiao@chromium.org> Reviewed-by: John Chen <zuan@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/f46c7831ed20839665cccf1fae95df7d2412a049/chaps/session_impl.cc
,
Jan 9
|
|||||
►
Sign in to add a comment |
||||||||
Comment 1 by menghuan@chromium.org
, Dec 27