Test for ImageProcessor |
|
Issue descriptionWe should have a test for ImageProcessor. https://cs.chromium.org/chromium/src/media/gpu/image_processor.h The test shall work on Trybot because we have LibYuVImageProcessor. Besides, when the test run on Chrome OS, it should try to use platform ImageProcessor (e.g. V4L2ImageProcessor).
,
Dec 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa719808f3e9c8db99598b2c451c857d3d84f206 commit aa719808f3e9c8db99598b2c451c857d3d84f206 Author: Hirokazu Honda <hiroh@chromium.org> Date: Thu Dec 27 11:16:59 2018 media/gpu: Add MEDIA_GPU_EXPORT to ImageProcessor MEDIA_GPU_EXPORT is required so that ImageProcessor is used outside of libmedia_gpu.so. A test for ImageProcessor is one of such examples. This is also required if we separate ImageProcessor part from VideoDecoder/VideoDecodeAccelerator and perform it in their client. TBR=posciak@chromium.org, acourbot@chromium.org Bug: 917951 Test: Compile chorme Change-Id: I5ea16bf3fd6d1dcde04cf71226f290304f50aa41 Reviewed-on: https://chromium-review.googlesource.com/c/1390784 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#619025} [modify] https://crrev.com/aa719808f3e9c8db99598b2c451c857d3d84f206/media/gpu/image_processor.h
,
Dec 28
The initial patch is uploaded, though it is WIP as I will sort up and write some comments. https://chromium-review.googlesource.com/c/chromium/src/+/1391664
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c2cd951c81337619852d0c47f1ee839378654a7 commit 3c2cd951c81337619852d0c47f1ee839378654a7 Author: Hirokazu Honda <hiroh@chromium.org> Date: Thu Jan 17 14:21:38 2019 media/test/data: Add images for image_processor_test Add I420, NV12, YV21 bear images. Bug: 917951 Test: image_processor_test Change-Id: Icbf35171aabdd4e05dd472822480b8a0cfd3d833 Reviewed-on: https://chromium-review.googlesource.com/c/1390789 Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#623677} [modify] https://crrev.com/3c2cd951c81337619852d0c47f1ee839378654a7/media/test/data/README.md [add] https://crrev.com/3c2cd951c81337619852d0c47f1ee839378654a7/media/test/data/bear_320x192.i420.yuv [add] https://crrev.com/3c2cd951c81337619852d0c47f1ee839378654a7/media/test/data/bear_320x192.nv12.yuv [add] https://crrev.com/3c2cd951c81337619852d0c47f1ee839378654a7/media/test/data/bear_320x192.yv21.yuv |
|
►
Sign in to add a comment |
|
Comment 1 by hiroh@chromium.org
, Dec 27Labels: videoshortlist