New issue
Advanced search Search tips

Issue 917944 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 29
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 892347



Sign in to add a comment

paint/.../textarea-caret.html in webkit_layout_tests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 27

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of horo@chromium.org

paint/.../textarea-caret.html in webkit_layout_tests failing on multiple builders

Builders failed on: 
- Mac10.10 Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests
- Mac10.11 Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests

I think this was caused by this change https://chromium-review.googlesource.com/c/chromium/src/+/1366767.

 
Blocking: 892347
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe267c43f0baef2f01cffed1a0c2577bfd8f9f1c

commit fe267c43f0baef2f01cffed1a0c2577bfd8f9f1c
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Dec 27 05:24:35 2018

Mark textarea-caret.html Failure on Mac10.10 and 10.11

TBR=chrishtr@chromium.org

Bug:  917944 
Change-Id: I848ce8325b89f18a7bd4523c95594ed9f600ae28
Reviewed-on: https://chromium-review.googlesource.com/c/1390782
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619008}
[modify] https://crrev.com/fe267c43f0baef2f01cffed1a0c2577bfd8f9f1c/third_party/blink/web_tests/TestExpectations

Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f068b327dcb96629fd176a9581fcdfc408e4be15

commit f068b327dcb96629fd176a9581fcdfc408e4be15
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Sat Dec 29 00:33:26 2018

Adjust layout test to avoid vertical scrollbar.

The vertical scrollbar only appeared on some Mac bots,
and is most likely due to subpixel font sizing. This
CL forces an integral font size.

Bug:  917944 
Change-Id: I96e30a6b8a206b316ae4831e23245279a034c65e
Reviewed-on: https://chromium-review.googlesource.com/c/1391768
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619214}
[modify] https://crrev.com/f068b327dcb96629fd176a9581fcdfc408e4be15/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/f068b327dcb96629fd176a9581fcdfc408e4be15/third_party/blink/web_tests/paint/invalidation/forms/textarea-caret.html
[delete] https://crrev.com/cd6f155a01135de13ec02382b6e0996cafbaa63b/third_party/blink/web_tests/platform/linux/paint/invalidation/forms/textarea-caret-expected.txt
[modify] https://crrev.com/f068b327dcb96629fd176a9581fcdfc408e4be15/third_party/blink/web_tests/platform/mac-mac10.10/paint/invalidation/forms/textarea-caret-expected.png
[modify] https://crrev.com/f068b327dcb96629fd176a9581fcdfc408e4be15/third_party/blink/web_tests/platform/mac-mac10.11/paint/invalidation/forms/textarea-caret-expected.png
[modify] https://crrev.com/f068b327dcb96629fd176a9581fcdfc408e4be15/third_party/blink/web_tests/platform/mac/paint/invalidation/forms/textarea-caret-expected.png
[modify] https://crrev.com/f068b327dcb96629fd176a9581fcdfc408e4be15/third_party/blink/web_tests/platform/mac/paint/invalidation/forms/textarea-caret-expected.txt
[modify] https://crrev.com/f068b327dcb96629fd176a9581fcdfc408e4be15/third_party/blink/web_tests/platform/win/paint/invalidation/forms/textarea-caret-expected.txt

Status: Fixed (was: Available)

Sign in to add a comment