hterm: using touch gestures does not raise the window on CrOS |
||||
Issue descriptionChrome Version: 71.0.3578.94 (Official Build) (64-bit) Chrome OS Version: 11151.59.0 (Official Build) stable-channel nocturne Chrome OS Platform: Pixel Slate Steps To Reproduce: (1) Open Terminal (2) Bring a Chrome browser window into focus in front of Terminal (3) Touch the Terminal Expected Result: The Terminal comes into focus. Actual Result: Nothing happens. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? Clicking the terminal does provide focus. Please provide any additional information below. Attach a screen shot or log if possible. This may have the same root cause as crbug.com/839124
,
Jan 4
,
Jan 4
imo, this is a bug in Chrome on Chrome OS. it behaves correctly on Windows. i don't have a touchscreen device on Linux/macOS to check behavior there. filed issue 919222 to track fixing Chrome. in the meantime i can workaround it in hterm using the chrome.windows.update API and forcing the window to focus. but this only works when Chrome is an app ... it doesn't help on the open web. https://chromium-review.googlesource.com/1396046
,
Jan 12
,
Jan 12
The following revision refers to this bug: https://chromium.googlesource.com/apps/libapps/+/61a2ba0fc9808ad7d29a6ff55780ed54f2c47116 commit 61a2ba0fc9808ad7d29a6ff55780ed54f2c47116 Author: Mike Frysinger <vapier@chromium.org> Date: Sat Jan 12 18:09:46 2019 hterm: workaround touch focus bug on CrOS On CrOS, touch events in a window will not raise that window to the foreground. Since hterm captures touch events to provide its own scroll/gesture logic, this means touching the window when it's in the background leaves it in the background even as we process the events generated. On Windows, Chrome will automatically raise the window for us. So add a workaround for CrOS to force focus until Chrome is fixed. Bug: chromium:917938 Change-Id: If06f197b74b1b6b9b6b382dd3f85408d57a33cf9 Reviewed-on: https://chromium-review.googlesource.com/c/1396046 Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Vitaliy Shipitsyn <vsh@google.com> [modify] https://crrev.com/61a2ba0fc9808ad7d29a6ff55780ed54f2c47116/hterm/js/hterm_scrollport.js |
||||
►
Sign in to add a comment |
||||
Comment 1 by vapier@chromium.org
, Dec 27