IsDedicatedWorkerGlobalScope() shouldn't be called in WorkerGlobalScope's ctor |
|||
Issue descriptionDuring WorkerGlobalScope::WorkerGlobalScope(), IsDedicatedWorkerGlobalScope() is still even for dedicated workers as the vtable is not yet fully initialized. This causes WorkerGlobalScope::IsScriptFetchedOnMainThread() to be true for classic dedicated workers even if off-the-main-thread classic worker top-level script fetch is enabled. (This shouldn't affect observable behavior but causing DCHECK() failures in my CL as this causes double-initializing referrer policy and URL of WorkerGlobalScope). I feel it's better to catch this kind of things by clang, i.e. calling a virtual method that is overridden by a subclass of class A from a constructor of class A. But anyway I'll fix this particular bug in the worker.
,
Dec 28
I'm considering adding a new field in GlobalScopeCreationParams.
,
Jan 9
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64c8be686b405ef50b2e6a8ac9af583465d3a2eb commit 64c8be686b405ef50b2e6a8ac9af583465d3a2eb Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Tue Jan 15 02:59:12 2019 Introduce OffMainThreadWorkerScriptFetchOption Instead of WorkerGlobalScope::IsScriptFetchedOnMainThread() that doesn't work in the constructors, this CL introduces GlobalScopeCreationParams::off_main_thread_fetch_option. Bug: 917932 , 861564 Change-Id: I325b7bbe8400019ef182e95035a5eb1283bb23d4 Reviewed-on: https://chromium-review.googlesource.com/c/1394192 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#622698} [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope_proxy.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/dedicated_worker.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/dedicated_worker.h [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/dedicated_worker_test.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/experimental/thread_pool.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/global_scope_creation_params.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/global_scope_creation_params.h [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/main_thread_worklet_test.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/threaded_worklet_messaging_proxy.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/threaded_worklet_test.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/worker_global_scope.h [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/worker_thread_test.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/core/workers/worker_thread_test_helper.h [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope_test.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_proxy.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_test.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope_test.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/modules/webaudio/audio_worklet_thread_test.cc [modify] https://crrev.com/64c8be686b405ef50b2e6a8ac9af583465d3a2eb/third_party/blink/renderer/modules/worklet/animation_and_paint_worklet_thread_test.cc
,
Jan 15
This breaks the linux-jumbo-rel builder https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-jumbo-rel/11419 [2613/2739] LINK ./vr_pixeltests [2614/2739] LINK ./headless_example FAILED: headless_example python "../../build/toolchain/gcc_link_wrapper.py" --output="./headless_example" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -m64 -Werror -Wl,-O2 -Wl,--gc-sections -rdynamic -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -pie -Wl,-rpath-link=. -Wl,--disable-new-dtags -o "./headless_example" -Wl,--start-group @"./headless_example.rsp" -Wl,--end-group -ldl -lpthread -lrt -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lresolv -lgio-2.0 -lexpat -luuid -ldbus-1 -lXext -lX11 -lXcomposite -lXrender -lX11-xcb -lxcb -lXcursor -lXdamage -lXfixes -lXi -lXtst -lXss -lXrandr -lasound -lm -lz -lpci -lpangocairo-1.0 -lpango-1.0 -lcairo -latk-1.0 -latk-bridge-2.0 -latspi -lcups ld.lld: error: undefined symbol: blink::GlobalScopeCreationParams::GlobalScopeCreationParams(blink::KURL const&, blink::mojom::ScriptType, WTF::String const&, scoped_refptr<blink::WebWorkerFetchContext>, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator> const&, network::mojom::ReferrerPolicy, blink::SecurityOrigin const*, bool, blink::HttpsState, blink::WorkerClients*, blink::mojom::IPAddressSpace, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*, base::UnguessableToken const&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >, blink::V8CacheOptions, blink::WorkletModuleResponsesMap*, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider>, blink::BeginFrameProviderParams, blink::FeaturePolicy const*, base::UnguessableToken) >>> referenced by exported_jumbo_1.cc >>> exported/exported_jumbo_1.o:(std::__1::__unique_if<blink::GlobalScopeCreationParams>::__unique_single std::__1::make_unique<blink::GlobalScopeCreationParams, blink::KURL const&, blink::mojom::ScriptType&, WTF::String, scoped_refptr<blink::WebWorkerFetchContext>, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator>, network::mojom::ReferrerPolicy&, blink::SecurityOrigin const*, bool, blink::HttpsState, blink::WorkerClients*, blink::mojom::IPAddressSpace, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*, base::UnguessableToken&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >, blink::V8CacheOptions, std::nullptr_t, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider> >(blink::KURL const&, blink::mojom::ScriptType&, WTF::String&&, scoped_refptr<blink::WebWorkerFetchContext>&&, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator>&&, network::mojom::ReferrerPolicy&, blink::SecurityOrigin const*&&, bool&&, blink::HttpsState&&, blink::WorkerClients*&&, blink::mojom::IPAddressSpace&&, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*&&, base::UnguessableToken&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >&&, blink::V8CacheOptions&&, std::nullptr_t&&, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider>&&)) in archive obj/third_party/blink/renderer/core/exported/libexported.a clang: error: linker command failed with exit code 1 (use -v to see invocation) [2615/2739] LINK ./headless_shell FAILED: headless_shell python "../../build/toolchain/gcc_link_wrapper.py" --output="./headless_shell" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -m64 -Werror -Wl,-O2 -Wl,--gc-sections -rdynamic -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -pie -Wl,-rpath-link=. -Wl,--disable-new-dtags -o "./headless_shell" -Wl,--start-group @"./headless_shell.rsp" -Wl,--end-group -ldl -lpthread -lrt -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lresolv -lgio-2.0 -lexpat -luuid -ldbus-1 -lXext -lX11 -lXcomposite -lXrender -lX11-xcb -lxcb -lXcursor -lXdamage -lXfixes -lXi -lXtst -lXss -lXrandr -lasound -lm -lz -lpci -lpangocairo-1.0 -lpango-1.0 -lcairo -latk-1.0 -latk-bridge-2.0 -latspi -lcups ld.lld: error: undefined symbol: blink::GlobalScopeCreationParams::GlobalScopeCreationParams(blink::KURL const&, blink::mojom::ScriptType, WTF::String const&, scoped_refptr<blink::WebWorkerFetchContext>, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator> const&, network::mojom::ReferrerPolicy, blink::SecurityOrigin const*, bool, blink::HttpsState, blink::WorkerClients*, blink::mojom::IPAddressSpace, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*, base::UnguessableToken const&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >, blink::V8CacheOptions, blink::WorkletModuleResponsesMap*, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider>, blink::BeginFrameProviderParams, blink::FeaturePolicy const*, base::UnguessableToken) >>> referenced by exported_jumbo_1.cc >>> exported/exported_jumbo_1.o:(std::__1::__unique_if<blink::GlobalScopeCreationParams>::__unique_single std::__1::make_unique<blink::GlobalScopeCreationParams, blink::KURL const&, blink::mojom::ScriptType&, WTF::String, scoped_refptr<blink::WebWorkerFetchContext>, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator>, network::mojom::ReferrerPolicy&, blink::SecurityOrigin const*, bool, blink::HttpsState, blink::WorkerClients*, blink::mojom::IPAddressSpace, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*, base::UnguessableToken&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >, blink::V8CacheOptions, std::nullptr_t, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider> >(blink::KURL const&, blink::mojom::ScriptType&, WTF::String&&, scoped_refptr<blink::WebWorkerFetchContext>&&, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator>&&, network::mojom::ReferrerPolicy&, blink::SecurityOrigin const*&&, bool&&, blink::HttpsState&&, blink::WorkerClients*&&, blink::mojom::IPAddressSpace&&, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*&&, base::UnguessableToken&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >&&, blink::V8CacheOptions&&, std::nullptr_t&&, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider>&&)) in archive obj/third_party/blink/renderer/core/exported/libexported.a clang: error: linker command failed with exit code 1 (use -v to see invocation) [2616/2739] LINK ./chrome_app_unittests [2617/2739] LINK ./chrome FAILED: chrome python "../../build/toolchain/gcc_link_wrapper.py" --output="./chrome" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--version-script=../../build/linux/chrome.map -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -m64 -Werror -Wl,-O2 -Wl,--gc-sections -rdynamic -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -pie -Wl,-rpath-link=. -Wl,--disable-new-dtags -o "./chrome" -Wl,--start-group @"./chrome.rsp" -Wl,--end-group -ldl -lpthread -lrt -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXtst -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lcups -ldbus-1 -lXss -lexpat -luuid -lXrandr -lresolv -lgio-2.0 -lasound -lm -lz -lpci -lpangocairo-1.0 -lpango-1.0 -lcairo -latk-1.0 -latk-bridge-2.0 -latspi -lgtk-3 -lgdk-3 -lgdk_pixbuf-2.0 -lcairo-gobject ld.lld: error: undefined symbol: blink::GlobalScopeCreationParams::GlobalScopeCreationParams(blink::KURL const&, blink::mojom::ScriptType, WTF::String const&, scoped_refptr<blink::WebWorkerFetchContext>, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator> const&, network::mojom::ReferrerPolicy, blink::SecurityOrigin const*, bool, blink::HttpsState, blink::WorkerClients*, blink::mojom::IPAddressSpace, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*, base::UnguessableToken const&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >, blink::V8CacheOptions, blink::WorkletModuleResponsesMap*, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider>, blink::BeginFrameProviderParams, blink::FeaturePolicy const*, base::UnguessableToken) >>> referenced by exported_jumbo_1.cc >>> exported/exported_jumbo_1.o:(std::__1::__unique_if<blink::GlobalScopeCreationParams>::__unique_single std::__1::make_unique<blink::GlobalScopeCreationParams, blink::KURL const&, blink::mojom::ScriptType&, WTF::String, scoped_refptr<blink::WebWorkerFetchContext>, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator>, network::mojom::ReferrerPolicy&, blink::SecurityOrigin const*, bool, blink::HttpsState, blink::WorkerClients*, blink::mojom::IPAddressSpace, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*, base::UnguessableToken&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >, blink::V8CacheOptions, std::nullptr_t, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider> >(blink::KURL const&, blink::mojom::ScriptType&, WTF::String&&, scoped_refptr<blink::WebWorkerFetchContext>&&, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator>&&, network::mojom::ReferrerPolicy&, blink::SecurityOrigin const*&&, bool&&, blink::HttpsState&&, blink::WorkerClients*&&, blink::mojom::IPAddressSpace&&, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*&&, base::UnguessableToken&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >&&, blink::V8CacheOptions&&, std::nullptr_t&&, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider>&&)) in archive obj/third_party/blink/renderer/core/exported/libexported.a clang: error: linker command failed with exit code 1 (use -v to see invocation) [2618/2739] LINK ./ntp_render_browsertests FAILED: ntp_render_browsertests python "../../build/toolchain/gcc_link_wrapper.py" --output="./ntp_render_browsertests" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -m64 -Werror -Wl,-O2 -Wl,--gc-sections -rdynamic -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -pie -Wl,-rpath-link=. -Wl,--disable-new-dtags -o "./ntp_render_browsertests" -Wl,--start-group @"./ntp_render_browsertests.rsp" -Wl,--end-group -ldl -lpthread -lrt -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -luuid -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXtst -lcups -ldbus-1 -lXss -lexpat -lXrandr -lresolv -lgio-2.0 -lasound -lm -lz -lpci -lpangocairo-1.0 -lpango-1.0 -lcairo -latk-1.0 -latk-bridge-2.0 -latspi -lgtk-3 -lgdk-3 -lgdk_pixbuf-2.0 -lcairo-gobject ld.lld: error: undefined symbol: blink::GlobalScopeCreationParams::GlobalScopeCreationParams(blink::KURL const&, blink::mojom::ScriptType, WTF::String const&, scoped_refptr<blink::WebWorkerFetchContext>, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator> const&, network::mojom::ReferrerPolicy, blink::SecurityOrigin const*, bool, blink::HttpsState, blink::WorkerClients*, blink::mojom::IPAddressSpace, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*, base::UnguessableToken const&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >, blink::V8CacheOptions, blink::WorkletModuleResponsesMap*, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider>, blink::BeginFrameProviderParams, blink::FeaturePolicy const*, base::UnguessableToken) >>> referenced by exported_jumbo_1.cc >>> exported/exported_jumbo_1.o:(std::__1::__unique_if<blink::GlobalScopeCreationParams>::__unique_single std::__1::make_unique<blink::GlobalScopeCreationParams, blink::KURL const&, blink::mojom::ScriptType&, WTF::String, scoped_refptr<blink::WebWorkerFetchContext>, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator>, network::mojom::ReferrerPolicy&, blink::SecurityOrigin const*, bool, blink::HttpsState, blink::WorkerClients*, blink::mojom::IPAddressSpace, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*, base::UnguessableToken&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >, blink::V8CacheOptions, std::nullptr_t, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider> >(blink::KURL const&, blink::mojom::ScriptType&, WTF::String&&, scoped_refptr<blink::WebWorkerFetchContext>&&, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator>&&, network::mojom::ReferrerPolicy&, blink::SecurityOrigin const*&&, bool&&, blink::HttpsState&&, blink::WorkerClients*&&, blink::mojom::IPAddressSpace&&, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*&&, base::UnguessableToken&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >&&, blink::V8CacheOptions&&, std::nullptr_t&&, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider>&&)) in archive obj/third_party/blink/renderer/core/exported/libexported.a clang: error: linker command failed with exit code 1 (use -v to see invocation) [2619/2739] LINK ./captured_sites_interactive_tests FAILED: captured_sites_interactive_tests python "../../build/toolchain/gcc_link_wrapper.py" --output="./captured_sites_interactive_tests" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -Wl,--color-diagnostics -m64 -Werror -Wl,-O2 -Wl,--gc-sections -rdynamic -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -pie -Wl,-rpath-link=. -Wl,--disable-new-dtags -o "./captured_sites_interactive_tests" -Wl,--start-group @"./captured_sites_interactive_tests.rsp" -Wl,--end-group -ldl -lpthread -lrt -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -luuid -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXtst -lcups -ldbus-1 -lXss -lexpat -lXrandr -lresolv -lgio-2.0 -lasound -lm -lz -lpci -lpangocairo-1.0 -lpango-1.0 -lcairo -latk-1.0 -latk-bridge-2.0 -latspi -lgtk-3 -lgdk-3 -lgdk_pixbuf-2.0 -lcairo-gobject ld.lld: error: undefined symbol: blink::GlobalScopeCreationParams::GlobalScopeCreationParams(blink::KURL const&, blink::mojom::ScriptType, WTF::String const&, scoped_refptr<blink::WebWorkerFetchContext>, WTF::Vector<std::__1::pair<WTF::String, blink::ContentSecurityPolicyHeaderType>, 0u, WTF::PartitionAllocator> const&, network::mojom::ReferrerPolicy, blink::SecurityOrigin const*, bool, blink::HttpsState, blink::WorkerClients*, blink::mojom::IPAddressSpace, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const*, base::UnguessableToken const&, std::__1::unique_ptr<blink::WorkerSettings, std::__1::default_delete<blink::WorkerSettings> >, blink::V8CacheOptions, blink::WorkletModuleResponsesMap*, mojo::InterfacePtrInfo<service_manager::mojom::blink::InterfaceProvider>, blink::BeginFrameProviderParams, blink::FeaturePolicy const*, base::UnguessableToken) >>> referenced by exported_jumbo_1.cc ... Reverting.
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6 commit 4561166b9e8eb9e1f704b51a8961e4d31fc85bf6 Author: Dominic Battré <battre@chromium.org> Date: Tue Jan 15 08:31:45 2019 Revert "Introduce OffMainThreadWorkerScriptFetchOption" This reverts commit 64c8be686b405ef50b2e6a8ac9af583465d3a2eb. Reason for revert: Breaks linux-jumbo-rel see crbug.com/917932 Original change's description: > Introduce OffMainThreadWorkerScriptFetchOption > > Instead of WorkerGlobalScope::IsScriptFetchedOnMainThread() > that doesn't work in the constructors, this CL introduces > GlobalScopeCreationParams::off_main_thread_fetch_option. > > Bug: 917932 , 861564 > Change-Id: I325b7bbe8400019ef182e95035a5eb1283bb23d4 > Reviewed-on: https://chromium-review.googlesource.com/c/1394192 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622698} TBR=haraken@chromium.org,hiroshige@chromium.org,nhiroki@chromium.org Change-Id: I8692c0ef29d997d6f4dff658ffd7160a7ab35101 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 917932 , 861564 Reviewed-on: https://chromium-review.googlesource.com/c/1411592 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#622780} [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope_proxy.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/dedicated_worker.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/dedicated_worker.h [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/dedicated_worker_test.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/experimental/thread_pool.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/global_scope_creation_params.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/global_scope_creation_params.h [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/main_thread_worklet_test.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/threaded_worklet_messaging_proxy.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/threaded_worklet_test.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/worker_global_scope.h [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/worker_thread_test.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/core/workers/worker_thread_test_helper.h [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope_test.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_proxy.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_test.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope_test.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/modules/webaudio/audio_worklet_thread_test.cc [modify] https://crrev.com/4561166b9e8eb9e1f704b51a8961e4d31fc85bf6/third_party/blink/renderer/modules/worklet/animation_and_paint_worklet_thread_test.cc
,
Jan 15
I suspect the jumbo failure that caused the revert is a buildbot issue ( Issue 921967 ?), as the CL passed linux_jumbo_rel trybot before commit but failed on the waterfall bot. I'll run the trybot and reland after Issue 921967 is fixed.
,
Jan 18
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28103b0a84ba67d3a4a289fdfee475d3aa85dd27 commit 28103b0a84ba67d3a4a289fdfee475d3aa85dd27 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri Jan 18 02:57:25 2019 Reland "Introduce OffMainThreadWorkerScriptFetchOption" This reverts commit 4561166b9e8eb9e1f704b51a8961e4d31fc85bf6. Reason for revert: The failure was probably due to crbug.com/921967 and the issue was fixed. Original change's description: > Revert "Introduce OffMainThreadWorkerScriptFetchOption" > > This reverts commit 64c8be686b405ef50b2e6a8ac9af583465d3a2eb. > > Reason for revert: Breaks linux-jumbo-rel see crbug.com/917932 > > Original change's description: > > Introduce OffMainThreadWorkerScriptFetchOption > > > > Instead of WorkerGlobalScope::IsScriptFetchedOnMainThread() > > that doesn't work in the constructors, this CL introduces > > GlobalScopeCreationParams::off_main_thread_fetch_option. > > > > Bug: 917932 , 861564 > > Change-Id: I325b7bbe8400019ef182e95035a5eb1283bb23d4 > > Reviewed-on: https://chromium-review.googlesource.com/c/1394192 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#622698} > > TBR=haraken@chromium.org,hiroshige@chromium.org,nhiroki@chromium.org > > Change-Id: I8692c0ef29d997d6f4dff658ffd7160a7ab35101 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 917932 , 861564 > Reviewed-on: https://chromium-review.googlesource.com/c/1411592 > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622780} TBR=battre@chromium.org,haraken@chromium.org,hiroshige@chromium.org,nhiroki@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 917932 , 861564 Change-Id: I77ef643ca28c7a0fb69c88e76238652e75f8d226 Reviewed-on: https://chromium-review.googlesource.com/c/1419371 Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#623975} [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope_proxy.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/dedicated_worker.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/dedicated_worker.h [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/dedicated_worker_test.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/experimental/thread_pool.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/global_scope_creation_params.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/global_scope_creation_params.h [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/main_thread_worklet_test.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/threaded_worklet_messaging_proxy.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/threaded_worklet_test.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/worker_global_scope.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/worker_global_scope.h [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/worker_thread_test.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/core/workers/worker_thread_test_helper.h [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope_test.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_proxy.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope_test.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope_test.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/modules/webaudio/audio_worklet_thread_test.cc [modify] https://crrev.com/28103b0a84ba67d3a4a289fdfee475d3aa85dd27/third_party/blink/renderer/modules/worklet/animation_and_paint_worklet_thread_test.cc
,
Yesterday
(27 hours ago)
|
|||
►
Sign in to add a comment |
|||
Comment 1 by falken@chromium.org
, Dec 27