[chromeperf2] Add warning on alerts over very large ranges |
||
Issue descriptionWe recently got data back on a benchmark that had been disabled for many months. This caused hundreds of alerts to come in at once, and confused the sheriff rotation, since it wasn't clear what happened. It would be good to mark alerts (in the alerts table and in the graphs) somehow to note that there is a long time period (> 2 weeks maybe?) between the point that alerted and the previous data point. From https://github.com/catapult-project/catapult/issues/3636 *** Also, if a regression is relatively small, then it might be somewhat expensive for pinpoint to reproduce it. v2spa should warn when a pinpoint job will be unusually expensive.
,
Jan 2
Note that a huge problem on chromeperf v1 is that all the data points are evenly spaced, so that revisions 5 minutes apart look the same on the graph as revisions 1 year apart. This type of issue is a big part of the reason we had talked about changing the x axis to be time-based in v2. It may be enough to fix the x-axis, instead of creating a warning.
,
Jan 3
Thanks for the background, Annie! V2spa supports both fixed and true x-axes: in charts' gear icon menu, toggle Fixed X-Axis (default) to True X-Axis. https://v2spa-dot-chromeperf.appspot.com/#testSuite=system_health.memory_desktop&measurement=memory%253Achrome%253Aall_processes%253Areported_by_chrome%253Aeffective_size&bot=ChromiumPerf%253Alinux-perf&minRev=618502&maxRev=619686&natural= We can talk in services weekly about whether to make True X-Axis the default, and how that decision relates to other changes that could be made around the sheriffing workflow to address the underlying issue.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
I'm not sure if this is really a blocker for v2spa and more of just a nice to have.
,
Jan 16
(6 days ago)
+1, if this feature exists in v1 it isn't really noticeable. |
||
►
Sign in to add a comment |
||
Comment 1 by benjhayden@chromium.org
, Dec 26