New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 917878 link

Starred by 1 user
Status: Assigned
Owner:
█ sweilun@chromium.org
Last visit 18 days ago
Cc:
mea...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

17ms startup performance regression in LookalikeUrlNavigationObserver::GetMatchingDomain()

Project Member Reported by sampling...@uma-hrd.google.com.iam.gserviceaccount.com, Dec 26 
Data from the UMA Sampling Profiler shows that the canary population experienced an average regression of 17ms over the first 30 seconds of startup in

73.0.3645.0 canary
Windows 64-bit
browser process UI thread

The regression was detected between versions 73.0.3644.0 and 73.0.3645.0.

The following CL is suspected to have caused the regression because it touched functions that regressed or related code:

revision: 5b516e05f9a3b3d0a4535c2a4ad15aa0e630be86
summary: Add edit distance matching for lookalike URLs using top 500 domains
author: meacer@chromium.org

Please refer to the detailed execution profile difference for LookalikeUrlNavigationObserver::GetMatchingDomain() to understand what caused the regression: https://uma.googleplex.com/p/chrome/callstacks?sid=8cbb4d277a943ca17906aa4588071915

Comment 1 by sweilun@chromium.org, Dec 26

Status: Closed (was: Assigned)

Comment 2 by mpear...@chromium.org, Jan 10 

Closed because ... ?

Or should this have been re-assigned to meacer@?

Comment 3 by mpear...@chromium.org, Jan 15

Status: Assigned (was: Closed)
re-opening to answer the question in comment #2

Comment 4 by meacer@google.com, Jan 18 (4 days ago)

Cc: mea...@chromium.org
I refactored this code recently. GetMatchingDomain is now called asynchronously by LookalikeUrlNavigationObserver::PerformChecks and shouldn't block startup.

Is this still an issue?
►

Sign in to add a comment