New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment
link

Issue 917873: Split Bucket message in datastore

Reported by no...@chromium.org, Dec 26 Project Member

Issue description

Project/chromium/BucketV2/ci is ~22Kb because contains definitions of all flattened builders. This entity is loaded to compute a role of a user, for each build.

Move builder definitions to separate entities, children of BucketV2.
 

Comment 1 by no...@chromium.org, Dec 26

Cc: vadimsh@chromium.org

Comment 2 by bugdroid1@chromium.org, Dec 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/ee0fce909c40785380d73c83ee1084ad072ba654

commit ee0fce909c40785380d73c83ee1084ad072ba654
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Dec 26 21:53:06 2018

[buildbucket] Make Builder message self-sufficient

Move non-builder fields in Swarming config message to Builder message, such that
Builder messages are self-sufficient.
This is preparation for moving Builder definitions to separate entities.

Bug: 917873
Change-Id: Ib2ef402cbc1c0606a5b6b21f6a5004b85bfdcff8
Reviewed-on: https://chromium-review.googlesource.com/c/1390977
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

[modify] https://crrev.com/ee0fce909c40785380d73c83ee1084ad072ba654/buildbucket/proto/config/project_config.pb.go
[modify] https://crrev.com/ee0fce909c40785380d73c83ee1084ad072ba654/buildbucket/proto/config/project_config.proto

Comment 3 by bugdroid1@chromium.org, Jan 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b769af031ef6dd113768cb78aa13cc274bf02a92

commit b769af031ef6dd113768cb78aa13cc274bf02a92
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Jan 10 23:50:13 2019

[buildbucket] Copy fields from swarming message

Copy swarming hostname and canary percentage from Swarming to Builder message.
Context: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1390977
This makes Builder message self-sufficient in the datastore.

Bug: 917873
Change-Id: Iaa8b61b12e96c59ce471c4e3aeb5c4b5976aa4a8
Reviewed-on: https://chromium-review.googlesource.com/c/1391389
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19914}
[modify] https://crrev.com/b769af031ef6dd113768cb78aa13cc274bf02a92/appengine/cr-buildbucket/config.py
[modify] https://crrev.com/b769af031ef6dd113768cb78aa13cc274bf02a92/appengine/cr-buildbucket/test/config_test.py

Comment 4 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7c96e166cf647319e9cdb0124c8b31183b2da4cc

commit 7c96e166cf647319e9cdb0124c8b31183b2da4cc
Author: Nodir Turakulov <nodir@google.com>
Date: Wed Jan 16 23:41:06 2019

[buildbucket] Stop reading swarming_cfg

Swarming message fields are now being copied to builders, so read them from
there. This removes swarming_cfg propagation in swarming.py

Also expose swarming_hostname in get_builders API. Nobody needs this, but
it is more correct.

Bug: 917873
Change-Id: Ide5d038a0cb016327f1d85824513d0375807d8a0
Reviewed-on: https://chromium-review.googlesource.com/c/1415570
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20039}
[modify] https://crrev.com/7c96e166cf647319e9cdb0124c8b31183b2da4cc/appengine/cr-buildbucket/swarming/swarming.py
[modify] https://crrev.com/7c96e166cf647319e9cdb0124c8b31183b2da4cc/appengine/cr-buildbucket/swarming/test/swarmbucket_api_test.py
[modify] https://crrev.com/7c96e166cf647319e9cdb0124c8b31183b2da4cc/appengine/cr-buildbucket/swarming/test/swarming_test.py
[modify] https://crrev.com/7c96e166cf647319e9cdb0124c8b31183b2da4cc/appengine/cr-buildbucket/swarming/swarmbucket_api.py

Comment 5 by no...@chromium.org, Jan 24

Status: Assigned (was: Started)

Comment 6 by no...@chromium.org, Jan 27

Cc: jclinton@chromium.org
Labels: -Pri-3 Pri-1
This blocks Chrome OS defining thousands of builders

Comment 7 by no...@chromium.org, Feb 12

Labels: -Pri-1 Pri-2

Sign in to add a comment