Migrate AWM to messages.google.com |
|
Issue descriptionMessages for Web is planning to migrate their domain from "messages.android.com" to "messages.google.com" along with the launch of their front-end rewrite. The ChromeOS integration hard-codes the "Messages for Web" domain for use in PWA installation, sending messages to the Service worker, reading cookies etc. See go/awm-cros-domain.
,
Dec 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/200f43b2123f5346b570c777d0a8248d21427292 commit 200f43b2123f5346b570c777d0a8248d21427292 Author: Kyle Horimoto <khorimoto@chromium.org> Date: Thu Dec 27 23:30:37 2018 [CrOS MultiDevice] Return messages.google.com when flag is enabled. This CL updates GetAndroidMessagesURL() to return different messages.google.com vs. messages.android.com depending on whether the kUseMessagesGoogleComDomain flag is enabled. Bug: 917855 Change-Id: Iff614146b3cd4d8d41d381f90cc5ee6530284a68 Reviewed-on: https://chromium-review.googlesource.com/c/1391316 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#619088} [modify] https://crrev.com/200f43b2123f5346b570c777d0a8248d21427292/chrome/browser/chromeos/android_sms/android_sms_urls.cc [modify] https://crrev.com/200f43b2123f5346b570c777d0a8248d21427292/chrome/browser/chromeos/android_sms/android_sms_urls.h
,
Dec 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2af3a1ff4650f43b2db15767ca4a4656f993756 commit a2af3a1ff4650f43b2db15767ca4a4656f993756 Author: Kyle Horimoto <khorimoto@chromium.org> Date: Fri Dec 28 00:39:11 2018 [CrOS MultiDevice] Uninstall old Messages PWA if necessary. When the kUseMessagesGoogleComDomain is changed, the Messages PWA changes from one URL to another, resulting in two separate PWAs being installed. This CL adds a check before the PWA is installed to ensure that if a PWA had already been installed at the old URL, it will be uninstalled first before the new one is installed. Note: The extensions::util::GetInstalledPwaForUrl() function is used to determine whether a PWA is installed for a given URL, but that function crashes in tests because it relies on the ExtensionPrefs KeyedService being available. To work around this issue, I added a delegate class which is overridden in the test. Bug: 917855 Change-Id: Iaafdd7876b2ea9b8c2d047435e1e5215196bf97d Reviewed-on: https://chromium-review.googlesource.com/c/1391747 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#619100} [modify] https://crrev.com/a2af3a1ff4650f43b2db15767ca4a4656f993756/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc [modify] https://crrev.com/a2af3a1ff4650f43b2db15767ca4a4656f993756/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.h [modify] https://crrev.com/a2af3a1ff4650f43b2db15767ca4a4656f993756/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl_unittest.cc
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68bd8c75f94041c5032b3aeca7e4bec2d1c69a8a commit 68bd8c75f94041c5032b3aeca7e4bec2d1c69a8a Author: Kyle Horimoto <khorimoto@chromium.org> Date: Fri Jan 04 00:41:23 2019 [CrOS MultiDevice] Add metric for Messages PWA uninstallation. This metric measures the boolean success/failure result of the app uninstallation. Bug: 917855 Change-Id: Iad12046f28b647cf58cb6f22aa6862ff086204ef Reviewed-on: https://chromium-review.googlesource.com/c/1392011 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#619832} [modify] https://crrev.com/68bd8c75f94041c5032b3aeca7e4bec2d1c69a8a/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc [modify] https://crrev.com/68bd8c75f94041c5032b3aeca7e4bec2d1c69a8a/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl_unittest.cc [modify] https://crrev.com/68bd8c75f94041c5032b3aeca7e4bec2d1c69a8a/tools/metrics/histograms/histograms.xml
,
Jan 18
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f08915e6b745a1ca48ca59de88fd217ab07cbfdc commit f08915e6b745a1ca48ca59de88fd217ab07cbfdc Author: Kyle Horimoto <khorimoto@chromium.org> Date: Fri Jan 18 01:12:02 2019 [CrOS MultiDevice] Add AndroidSmsAppSetupController. This class provides utility functions used to install/uninstall the AndroidSms PWA at a given URL as well as adding the DefaultToPersist cookie which defaults the "remember this device" toggle to on. AndroidSmsAppSetupController contains much of the logic residing in AndroidSmsAppHelperDelegateImpl; however, that class did not provide any notice when an installation/uninstallation request succeeded or failed, so it was inadequate for migrating from one domain to another, since an app should only be uninstalled if the previous installation succeeded. A follow-up CL will actually use this new class and will refactor AndroidSmsAppHelperDelegateImpl to use the new class directly. Bug: 917855 Change-Id: I9827486b1d6eb697202097152bad77630d745337 Reviewed-on: https://chromium-review.googlesource.com/c/1416821 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#623935} [modify] https://crrev.com/f08915e6b745a1ca48ca59de88fd217ab07cbfdc/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/f08915e6b745a1ca48ca59de88fd217ab07cbfdc/chrome/browser/chromeos/android_sms/android_sms_app_setup_controller.h [add] https://crrev.com/f08915e6b745a1ca48ca59de88fd217ab07cbfdc/chrome/browser/chromeos/android_sms/android_sms_app_setup_controller_impl.cc [add] https://crrev.com/f08915e6b745a1ca48ca59de88fd217ab07cbfdc/chrome/browser/chromeos/android_sms/android_sms_app_setup_controller_impl.h [add] https://crrev.com/f08915e6b745a1ca48ca59de88fd217ab07cbfdc/chrome/browser/chromeos/android_sms/android_sms_app_setup_controller_impl_unittest.cc [add] https://crrev.com/f08915e6b745a1ca48ca59de88fd217ab07cbfdc/chrome/browser/chromeos/android_sms/fake_android_sms_app_setup_controller.cc [add] https://crrev.com/f08915e6b745a1ca48ca59de88fd217ab07cbfdc/chrome/browser/chromeos/android_sms/fake_android_sms_app_setup_controller.h |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Dec 26