Once crbug.com/917836 is fixed, SigninErrorController will be a client of the core identity code rather than inside it. As such, it should then be ported to talk to IdentityManager.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b49d39ad8357973f1fc68e020e94d8d015be8d5a commit b49d39ad8357973f1fc68e020e94d8d015be8d5a Author: Colin Blundell <blundell@chromium.org> Date: Mon Jan 07 10:03:48 2019 Add IdentityTestEnvironment wrapper of identity_test_utils method This small CL simply adds an IdentityTestEnv wrapper of an underlying identity_test_utils method for convenience. The wrapper will be used in an upcoming CL. Bug: 917837 Change-Id: Ib62f1b4a6eea9a91bfc4ec0074bb5c1090907e1e Reviewed-on: https://chromium-review.googlesource.com/c/1393326 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#620279} [modify] https://crrev.com/b49d39ad8357973f1fc68e020e94d8d015be8d5a/services/identity/public/cpp/identity_test_environment.cc [modify] https://crrev.com/b49d39ad8357973f1fc68e020e94d8d015be8d5a/services/identity/public/cpp/identity_test_environment.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61c407fc3998d13b1e25d84ae935b45a56e1a116 commit 61c407fc3998d13b1e25d84ae935b45a56e1a116 Author: Colin Blundell <blundell@chromium.org> Date: Mon Jan 07 10:06:06 2019 Add IdentityManager::Observer method for refresh token error changes This CL adds an IdentityManager::Observer method that is the logical equivalent of OAuth2TokenService::OnAuthErrorChanged(). This new method will be used in an upcoming conversion. This API passes the AccountInfo of the affected account for consistency with IdentityManager::OnRefreshTokenUpdatedForAccount(), which also passes the AccountInfo. Bug: 917837 Change-Id: I3f9cd82b0d3d6725207a48dcb64f22dd180092e5 Reviewed-on: https://chromium-review.googlesource.com/c/1393327 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#620280} [modify] https://crrev.com/61c407fc3998d13b1e25d84ae935b45a56e1a116/services/identity/public/cpp/identity_manager.cc [modify] https://crrev.com/61c407fc3998d13b1e25d84ae935b45a56e1a116/services/identity/public/cpp/identity_manager.h [modify] https://crrev.com/61c407fc3998d13b1e25d84ae935b45a56e1a116/services/identity/public/cpp/identity_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2218b86f3e8c4d4f61ef3f71d5c1a7f1fe60ae66 commit 2218b86f3e8c4d4f61ef3f71d5c1a7f1fe60ae66 Author: Colin Blundell <blundell@chromium.org> Date: Mon Jan 07 16:22:23 2019 Port SigninErrorController to IdentityManager This CL ports SigninErrorController away from talking to SigninManager and ProfileOAuth2TokenService in favor of talking to IdentityManager. It is a step on the path to removing all direct consumers of SigninManager/PO2TS outside of //services/identity. The conversion is straightforward. To verify it, I did the manual testing described in https://chromium-review.googlesource.com/c/chromium/src/+/1390012. TBR=droger@chromium.org Bug: 917837 Change-Id: I113c4ffa2002da57d8d240035e98aee6ff86a554 Reviewed-on: https://chromium-review.googlesource.com/c/1392094 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#620343} [modify] https://crrev.com/2218b86f3e8c4d4f61ef3f71d5c1a7f1fe60ae66/chrome/browser/signin/dice_response_handler_unittest.cc [modify] https://crrev.com/2218b86f3e8c4d4f61ef3f71d5c1a7f1fe60ae66/chrome/browser/signin/signin_error_controller_factory.cc [modify] https://crrev.com/2218b86f3e8c4d4f61ef3f71d5c1a7f1fe60ae66/components/signin/core/browser/signin_error_controller.cc [modify] https://crrev.com/2218b86f3e8c4d4f61ef3f71d5c1a7f1fe60ae66/components/signin/core/browser/signin_error_controller.h [modify] https://crrev.com/2218b86f3e8c4d4f61ef3f71d5c1a7f1fe60ae66/components/signin/core/browser/signin_error_controller_unittest.cc [modify] https://crrev.com/2218b86f3e8c4d4f61ef3f71d5c1a7f1fe60ae66/ios/chrome/browser/signin/signin_error_controller_factory.cc [modify] https://crrev.com/2218b86f3e8c4d4f61ef3f71d5c1a7f1fe60ae66/ios/web_view/BUILD.gn [modify] https://crrev.com/2218b86f3e8c4d4f61ef3f71d5c1a7f1fe60ae66/ios/web_view/internal/signin/web_view_signin_error_controller_factory.mm [modify] https://crrev.com/2218b86f3e8c4d4f61ef3f71d5c1a7f1fe60ae66/ios/web_view/internal/sync/cwv_sync_controller_unittest.mm
Comment 1 by blundell@chromium.org
, Dec 28Status: Started (was: Available)