New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 917793 link

Starred by 2 users
Status: Fixed
Owner:
robertma@chromium.org
Closed: Jan 9
Cc:
█ andreasbutler@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

File removal is not reflected in MANIFEST.json

Project Member Reported by hirosh...@chromium.org, Dec 26 
ToT (r618847).

What steps will reproduce the problem?
(1) Remove a WPT test.
(2) Run web tests (locally or on trybots).

Example: https://chromium-review.googlesource.com/c/chromium/src/+/1390268

What is the expected result?

Tests runs successfully, without executing the removed WPT test.

What happens instead?

The WPT test was still executed and caused a test failure (see trybot results of the CL above),
because an entry for the removed WPT test remained in the base manifest (web_tests/external/WPT_BASE_MANIFEST_5.json) and generated manifest (web_tests/external/wpt/MANIFEST.json).

Updating the base manifest resolved the failure:

$ rm third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
$ ./third_party/blink/tools/run_web_tests.py ... (which triggers regeneration of wpt/MANIFEST.json from scratch)
$ cp third_party/blink/web_tests/external/wpt/MANIFEST.json third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json

https://chromium-review.googlesource.com/c/chromium/src/+/1390334

Is this a bug in manifest generation, or should I update the base manifest manually?

Comment 1 by robertma@chromium.org, Jan 8

Owner: robertma@chromium.org
Status: Started (was: Untriaged)
This was broken in upstream. I've landed a fix on GitHub: https://github.com/web-platform-tests/wpt/pull/14728

The fix will be rolled into Chromium in https://chromium-review.googlesource.com/c/chromium/src/+/1400952
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f95b30a08d21969c81158b54511659fb457673

commit 90f95b30a08d21969c81158b54511659fb457673
Author: Robert Ma <robertma@chromium.org>
Date: Wed Jan 09 18:06:59 2019

[blinkpy] Roll WPT tools to fix a manifest issue

Upstream bug: https://github.com/web-platform-tests/wpt/issues/14568
Fix: https://github.com/web-platform-tests/wpt/pull/14728

Another symptom of the issue is that Chromium CQ may report deleted
tests as MISSING/ERROR.

Bug:  917793 
Change-Id: If6fbba02378dbb57cd50b0b6e51a7aaed6a6f6a9
Reviewed-on: https://chromium-review.googlesource.com/c/1400952
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621217}
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/README.chromium
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/checkout.sh
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/wpt/.gitignore
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/manifest/manifest.py
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/browser.py
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/install.py
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/run.py
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/testfiles.py
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/config.py
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/base.py
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/openssl.py
[modify] https://crrev.com/90f95b30a08d21969c81158b54511659fb457673/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/pregenerated.py

Comment 3 by robertma@chromium.org, Jan 9

Cc: andreasbutler@chromium.org
Status: Fixed (was: Started)
Should be fixed now.

CC Andreas, feel free to reopen it if you are still seeing the problem.

Comment 4 by hirosh...@chromium.org, Jan 9 

Thanks! The issue seems fixed!
►

Sign in to add a comment