New issue
Advanced search Search tips

Issue 917714 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

fast/js/try-catch-crash.html fails after v8 roll

Project Member Reported by avi@google.com, Dec 24

Issue description

Status: Untriaged (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e49c86c9b8f2f6b49275eeccdc1cdd767cade3a9

commit e49c86c9b8f2f6b49275eeccdc1cdd767cade3a9
Author: Avi Drissman <avi@chromium.org>
Date: Mon Dec 24 21:39:09 2018

Un-roll V8.

fast/js/try-catch-crash.html failed after
https://chromium-review.googlesource.com/c/chromium/src/+/1388160;
revert that roll.

BUG= 917714 
TBR=hablich@chromium.org

Change-Id: I1da33bfea7d1a06fc8cefb38f210127fef840b2a
Reviewed-on: https://chromium-review.googlesource.com/c/1390431
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618834}
[modify] https://crrev.com/e49c86c9b8f2f6b49275eeccdc1cdd767cade3a9/DEPS

Summary: fast/js/try-catch-crash.html fails after v8 roll (was: fast/js/try-catch-crash.html fails after v8 roll?)
This is confirmed; https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/76671 just passed try-catch-crash.html after the unroll.

Something in https://chromium.googlesource.com/v8/v8/+log/cdef3415..3be90857 is breaking that test; please work out what the source of the failure is before resuming the rolls.
Owner: u...@chromium.org
Status: Assigned (was: Untriaged)
I can reproduce the failure locally. Investigating.
This bisects to 2d2c137 Reland^2 "[turbofan] Use feedback when reducing global loads/stores.":
https://chromium.googlesource.com/v8/v8/+/2d2c1374929c7ff41bed6526103ba6217009057a
Cc: ishell@chromium.org u...@chromium.org
Owner: neis@chromium.org
The CL slows down the test by ~5x. Adding "var" to the loop variable in the test fixes the regression.

As I am not sure what is the right fix here, I am going to revert the CL and start V8's autoroller.

Status: Fixed (was: Assigned)
Thanks for taking care fo this. I'll investigate further.
Cc: verwa...@chromium.org tzik@chromium.org mslekova@chromium.org
 Issue 917366  has been merged into this issue.
Thanks Ulan for taking care of this!
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/205f94d706457ab4ca0d06491db80bbb40944914

commit 205f94d706457ab4ca0d06491db80bbb40944914
Author: Georg Neis <neis@chromium.org>
Date: Fri Jan 11 14:44:33 2019

Avoid global loop counter variables in some tests

The use of a global variable as loop counter in these tests is
unnecessary (perhaps accidental), and a pending change in how V8
optimizes global loads and stores causes one of the tests
(fast/js/try-catch-crash.html) to time out in an msan build.

Bug:  chromium:917714 
Change-Id: Iadd53929873f4a7b6b1d4683aa3081ee2d0f1d86
Reviewed-on: https://chromium-review.googlesource.com/c/1406727
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622003}
[modify] https://crrev.com/205f94d706457ab4ca0d06491db80bbb40944914/third_party/blink/manual_tests/array-out-of-memory.html
[modify] https://crrev.com/205f94d706457ab4ca0d06491db80bbb40944914/third_party/blink/manual_tests/autoscroll.html
[modify] https://crrev.com/205f94d706457ab4ca0d06491db80bbb40944914/third_party/blink/manual_tests/harfbuzz-mouse-selection-crash.html
[modify] https://crrev.com/205f94d706457ab4ca0d06491db80bbb40944914/third_party/blink/manual_tests/input-starved-by-timers.html
[modify] https://crrev.com/205f94d706457ab4ca0d06491db80bbb40944914/third_party/blink/manual_tests/select_hr.html
[modify] https://crrev.com/205f94d706457ab4ca0d06491db80bbb40944914/third_party/blink/web_tests/fast/js/try-catch-crash.html
[modify] https://crrev.com/205f94d706457ab4ca0d06491db80bbb40944914/third_party/blink/web_tests/media/video-played.js

Sign in to add a comment