New issue
Advanced search Search tips

Issue 917711 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-01-03
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Shaping of Gurmukhi sequence interrupted by dotted circle after HarfBuzz roll

Reported by inderpre...@gmail.com, Dec 24

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Example URL:
https://inderpreet99.github.io/diacritic-test.html

Steps to reproduce the problem:
1. Go to the above URL
2. Notice how the text appears separated from their diacritic marks in stable Chrome >= 71

What is the expected behavior?
The expected behavior is that the text appears together without the breaks between the diacritics and characters, so that it appears as one word. Like it does in old Chrome or latest Firefox.

What went wrong?
Somewhere in Chrome 71+, the text became broken. Works perfectly in Chrome 70.0.3538.0.

It seems the diacritics aren't properly merging between the characters or moving to the right place (GPOS).

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes 70.0.3538.0

Does this work in other browsers? Yes

Chrome version: 71.0.3578.98  Channel: stable
OS Version: 10.0
Flash Version: 

It's broken in Chrome canary (73.0.3650.0) as well.
 
rendering-chrome-firefox.png
19.1 KB View Download
Just noting that the behavior is the same on Macs as well.
Bisected to r603037 "Roll HarfBuzz to contain emoji cluster formation"
Landed in 72.0.3593.0
Merged to 71.0.3578.28
Labels: Needs-Bisect Needs-Triage-M71
Cc: viswa.karala@chromium.org
Components: Blink>Fonts>Emoji
Labels: -Type-Bug -Pri-2 -Needs-Bisect RegressedIn-71 ReleaseBlock-Stable Triaged-ET Target-71 Target-72 Target-73 M-71 FoundIn-71 FoundIn-73 FoundIn-72 hasbisect OS-Linux Pri-1 Type-Bug-Regression
Owner: drott@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported version# 71.0.3578.98 and on latest chrome# 73.0.3651.0 using Windows-10 and Ubuntu 17.10 hence providing Bisect Info
Note: Issue is not seen on Mac 10.12.6

Bisect Info:
================
Good build: 71.0.3578.27
Bad build: 71.0.3578.28

As the issue break is seen in 71.0.3578 branch builds, hence providing below change-log from omahaproxy
Change-Log: https://chromium.googlesource.com/chromium/src/+log/71.0.3578.27..71.0.3578.28?pretty=fuller&n=10000
Suspecting: https://chromium.googlesource.com/chromium/src/+/746156f503ddf75d5037574c27889eb0030e37f6 from above change log
Change-Id: I34d22a48ec8e4a9a627b12c68efefaabdcd015c7
Reviewed-on: https://chromium-review.googlesource.com/c/1264519

@Dominik Röttsches: Please confirm the issue and help in re-assigning if it is not related to your change.
Adding ReleaseBlock-Stable for M-71, feel free to remove it if not applicable.

Thanks!
Components: -Blink
Labels: -Target-71
Let's target 72/73 for this. 
Labels: -M-71
Cc: behdad@chromium.org
Status: ExternalDependency (was: Assigned)
Reported as https://github.com/harfbuzz/harfbuzz/issues/1516

NextAction: 2019-01-03
Summary: Shaping of Gurmukhi sequence interrupted by dotted circle after HarfBuzz roll (was: UTF8 diacritic marks broken in latest Chrome)
As noted in https://github.com/harfbuzz/harfbuzz/issues/1516#issuecomment-450181694, these are sequences that according to Unicode should *not* be used; there are separately-encoded atomic characters that should be used instead. See table 12-16 in the Unicode standard.
Project Member

Comment 13 by sheriffbot@chromium.org, Dec 28

This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Jan 1

This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: ExternalDependency)
Closing as WontFix as discussed in https://github.com/harfbuzz/harfbuzz/issues/1516 - Unicode recommends not using the first of the two mentioned sequences. Table 12-16 in http://www.unicode.org/versions/Unicode11.0.0/ch12.pdf has the recommended encodings. We follow this recommendation in that we insert dotted circle characters when the invalid encodings are used, as do other implementations such as Word and WordPad on Windows and others. 

If the reporter objects to those recommendations, the issue should be raised with the Unicode consortium or in Unicode mailing list.
The NextAction date has arrived: 2019-01-03

Sign in to add a comment