Manually uprev Chrome to 73.0.3648.0 or newer for ChromeOS |
||||||
Issue descriptionDue to a series of infrastructure issues crbug.com/917193, we have not had a Chrome uprev since 2018-12-18 This PFQ run: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?id=3266591 only had these failing children: https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Prod/b8926389153097444720 and the failure was due to crbug.com/917193 (Filed by following the instructions at go/dmmdp )
,
Dec 24
From "git ls-remote" on the temporary directory, I see these candidates: 44507452f50c693c1c6bbec23bc2fea517bc9396 refs/pfq/staging_pfq_branch_3254279 4b9722149e0a8f01aef8014414877ddd122720b6 refs/pfq/staging_pfq_branch_3257002 f21b5f49e18473c3006018f2604d0603aa7e3d64 refs/pfq/staging_pfq_branch_3264218 2f466e5554f4d7266191a1f0c54e2a1a840ccd81 refs/pfq/staging_pfq_branch_3267260 4f3d12496bb96f88c968a2c79385089d2ab9c039 refs/pfq/staging_pfq_branch_847403 ...so it certainly seems like some tooling has changed and broken the uprev tool (grr...)
,
Dec 24
Well, feels like I'm stuck at this point. I tried reading through the docs, and example commits, but can't figure out how to "safely" uprev Chrome at this point, so we're still stuck with a version of Chrome with broken graphics on some platforms.
,
Dec 26
,
Dec 28
,
Dec 28
I think https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?id=3284763 would be a good candidate for a manual uprev, as the only failure was on tricky, and that was a new failure caused by a bad SSD (see Issue 918153 ). Unfortunately, I've been fighting the MySQL installation on my machine for hours, and have been unable to get "cros uprevchrome" to work :-( If we don't get an uprev over the weekend, then I'll pass this along to next week's gardener. Sorry I couldn't get this done.
,
Dec 30
Per #6, I was able to run "cros uprevchrome --pfq-build 3284763 -- bug chromium:917661 " successfully. Here are the changes that were created if, if anyone wants to review and chump them: https://crrev.com/c/1392825 https://crrev.com/i/757310 No warranty, though: I probably won't be available to repair things if uprevving causes problems. :-P
,
Dec 31
Passing to next week's gardener, since I don't want to chump derat@'s CLs while everyone's OOO. NOTE: Issue 917623 seems to be what's currently blocking a successful PFQ run. All child builders have been green for a couple of days ( https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?id=3287915 ), (except kevin, which is currently marked experimental Issue 917193).
,
Jan 2
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/acb3bb99e9e9de0d6770c358e769b07c6ddfa146 commit acb3bb99e9e9de0d6770c358e769b07c6ddfa146 Author: Daniel Erat <derat@chromium.org> Date: Wed Jan 02 17:29:41 2019 Manual Uprev Chrome: generated by cros_uprevchrome based on build_id 3284763, build_number 0 Marking set of ebuilds as stable Update PFQ config dump amd64-generic-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST arm-generic-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST daisy-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST veyron_jerry-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST amd64-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST Update profiles and manifests for Kernel. Update profiles and manifests for Chrome. Marking latest_release for chromium-source ebuild with version 73.0.3654.0 as stable. Marking latest_release for chromeos-chrome ebuild with version 73.0.3654.0 as stable. BUG= chromium:917661 TEST=None CQ-DEPEND=CL:*Ibce7e8a48aa92b6114373d96a16071ddb347af1c Change-Id: I2a42ad3fe9a4a175d835bfa6296a59d590efced0 Reviewed-on: https://chromium-review.googlesource.com/1392825 Commit-Ready: Nicolas Boichat <drinkcat@chromium.org> Tested-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Justin TerAvest <teravest@chromium.org> [rename] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/chromeos-base/chromeos-chrome/chromeos-chrome-73.0.3654.0_rc-r1.ebuild [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/chromeos/binhost/chromium.json [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/sys-kernel/chromeos-kernel-3_18/Manifest [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/chromeos-base/chromeos-chrome/Manifest [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/sys-kernel/chromeos-kernel-3_8/chromeos-kernel-3_8-9999.ebuild [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/chromeos/binhost/target/daisy-LATEST_RELEASE_CHROME_BINHOST.conf [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/sys-kernel/chromeos-kernel-4_4/Manifest [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/chromeos/binhost/target/arm-generic-LATEST_RELEASE_CHROME_BINHOST.conf [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/sys-kernel/chromeos-kernel-4_4/chromeos-kernel-4_4-9999.ebuild [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/sys-kernel/chromeos-kernel-3_18/chromeos-kernel-3_18-3.18-r2246.ebuild [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/chromeos/binhost/target/amd64-generic-LATEST_RELEASE_CHROME_BINHOST.conf [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/sys-kernel/chromeos-kernel-3_18/chromeos-kernel-3_18-9999.ebuild [rename] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/chromeos-base/chromium-source/chromium-source-73.0.3654.0_rc-r1.ebuild [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/sys-kernel/chromeos-kernel-3_14/Manifest [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/sys-kernel/chromeos-kernel-3_8/Manifest [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/chromeos/binhost/target/veyron_jerry-LATEST_RELEASE_CHROME_BINHOST.conf [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/sys-kernel/chromeos-kernel-3_8/chromeos-kernel-3_8-3.8.11-r756.ebuild [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/sys-kernel/chromeos-kernel-4_4/chromeos-kernel-4_4-4.4.169-r1775.ebuild [modify] https://crrev.com/acb3bb99e9e9de0d6770c358e769b07c6ddfa146/chromeos/binhost/host/amd64-LATEST_RELEASE_CHROME_BINHOST.conf
,
Jan 2
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-partner-overlay/+/52262a2c4fbd528c9fc89022d080f38f44df5ddb commit 52262a2c4fbd528c9fc89022d080f38f44df5ddb Author: Daniel Erat <derat@chromium.org> Date: Wed Jan 02 17:29:40 2019
,
Jan 2
Uprev commits are merged thanks to derat. Closing. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by teravest@google.com
, Dec 24