New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 917655 link

Starred by 3 users
Status: Fixed
Owner:
jinsuk...@chromium.org
Closed: Jan 14
Cc:
█ donnd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

"Sneak peek" from incognito tab does not open in incognito mode

Project Member Reported by p...@google.com, Dec 23 
Chrome Version: 73.0.3629.0 (Official Build) canary (32-bit)
OS: Android

What steps will reproduce the problem?
(1) Log in to monorail in a regular (non incognito) tab
(2) Open crbug.com in incognito tab
(3) Use "sneak peek" to view any issue page

What is the expected result?

The sneak peek should not show that I am logged in.

What happens instead?

It shows that I am logged in.

Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by tedc...@chromium.org, Jan 2

Components: UI>Browser>Navigation
Owner: jinsuk...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by jinsuk...@chromium.org, Jan 2

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4608cc6cd9815a1628febe28ef18e2f67871488

commit f4608cc6cd9815a1628febe28ef18e2f67871488
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Mon Jan 07 01:19:23 2019

EphemeralTab: Preserve incognito property

Ensures that ephemeral tab creates WebContents with incognito
profile if opened from an incognito tab.

Bug:  917655 
Change-Id: I404d0d11efe4890c8a1477d24b658fcae5d59559
Reviewed-on: https://chromium-review.googlesource.com/c/1394063
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620240}
[modify] https://crrev.com/f4608cc6cd9815a1628febe28ef18e2f67871488/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
[modify] https://crrev.com/f4608cc6cd9815a1628febe28ef18e2f67871488/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
[modify] https://crrev.com/f4608cc6cd9815a1628febe28ef18e2f67871488/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java
[modify] https://crrev.com/f4608cc6cd9815a1628febe28ef18e2f67871488/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/ephemeraltab/EphemeralTabPanel.java
[modify] https://crrev.com/f4608cc6cd9815a1628febe28ef18e2f67871488/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
[modify] https://crrev.com/f4608cc6cd9815a1628febe28ef18e2f67871488/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelEventFilterTest.java
[modify] https://crrev.com/f4608cc6cd9815a1628febe28ef18e2f67871488/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManagerTest.java
[modify] https://crrev.com/f4608cc6cd9815a1628febe28ef18e2f67871488/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFakeServer.java

Comment 4 by jinsuk...@chromium.org, Jan 14

Status: Fixed (was: Started)
►

Sign in to add a comment