Findit identified the culprit r618713 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWY0Y2U5N2UxNmY0YTdjMWQ1N2Y1Njg1YWQyMzA5MjMyODVjZjU0OQw Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r618713&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWY0Y2U5N2UxNmY0YTdjMWQ1N2Y1Njg1YWQyMzA5MjMyODVjZjU0OQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
FYI, I already reverted it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40b00c4bcb4ed2ac12dd977f07aff072cca356f8 commit 40b00c4bcb4ed2ac12dd977f07aff072cca356f8 Author: Vladimir Levin <vmpstr@chromium.org> Date: Wed Jan 02 21:04:12 2019 Reland "[DL]: Ensure to reject update/commit promises on disconnected elements." This reverts commit a36e6e1d9422377bb173d2c1139e66276933c51c, which reverted the initial patch. The original patch description is: """ This patch ensures that we reject update/commit when it happens on a disconnected element. """ The changes in this CL include: - Ensuring that we can commit a disconnected element, since it just unlocks the lock - Ensuring that a timeout triggered on a disconnected element does not DCHECK (this was the cause of the revert to begin with) - Updates the test to have an explicit infinite timeout if timeout is not being tested, since bots can be slow and timeout the lock thus making tests flaky. - Adds a test for timeout on disconnected element. R=chrishtr@chromium.org Bug: 917584 , 882663 Change-Id: I6a417fde2c6bd113959128c8bb33a865c97cac8b Reviewed-on: https://chromium-review.googlesource.com/c/1393346 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619490} [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/renderer/core/display_lock/display_lock_context.cc [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/renderer/core/display_lock/display_lock_context.h [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/acquire-commit.html [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/acquire-infinite-timeout-no-commit.html [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/acquire-update-measure-remove.html [add] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/acquire-update-remove-expected.html [add] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/acquire-update-remove.html [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/commit-on-added-containment.html [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/commit-on-inline-fails.html [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/commit-on-no-containment-fails.html [add] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/commit-while-disconnected-expected.html [add] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/commit-while-disconnected.html [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/measure-forced-layout.html [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/measure-updated-layout.html [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/multiple-acquires-all-succeed.html [add] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/timeout-while-disconnected-expected.html [add] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/timeout-while-disconnected.html [modify] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/update-together-with-commit-both-succeed.html [add] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/update-while-disconnected-expected.html [add] https://crrev.com/40b00c4bcb4ed2ac12dd977f07aff072cca356f8/third_party/blink/web_tests/display-lock/lock-before-append/update-while-disconnected.html
Comment 1 by avi@google.com
, Dec 26