[daisy] samsung chromebook, daisy board, fails updating from chromeos v70 to v71
Reported by
pa...@casaschi.net,
Dec 22
|
|||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS armv7l 11021.81.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36 Platform: 11021.81.0 (Official Build) stable-channel daisy Steps to reproduce the problem: Samsung chromebook, daisy board, fails updating from chromeos v70 to v71. The chromeos update page finds a new chromeos version, downloads the new image but ultimately fails to install it reporting that the device is up to date but still at the older version v70. Similar issue happened few weeks ago with the same device failing to update to v68 and v69, ultimately fixed for v70... now the issue is back for v71. What is the expected behavior? What went wrong? Something is broken in the install package; here is an excerpt from the chromeos log that might be relevant: Starting firmware updater (//usr/sbin/chromeos-firmwareupdate --mode=autoupdate) Command: //usr/sbin/chromeos-firmwareupdate --mode=autoupdate Starting Google_Snow firmware updater v5 (autoupdate)... ERROR: Your system platform is not compatible. >> Firmware updater started. quirk_daisy_snow_dual_model: Platform version: x16 (original value: MPx16) >> Target image: bios.bin (RO:Google_Snow.2695.132.0, RW/A:Google_Snow.2695.132.0, RW/B:Google_Snow.2695.132.0). Loading current system firmware... >> Current system: /tmp/fwupdater.6qsDWB (RO:Google_Snow_Rev4.2695.128.0, RW/A:Google_Snow.2695.132.0, RW/B:Google_Snow.2695.132.0). >> FAILED: Firmware updater stopped due to error. ERROR: Firmware update (autoupdate) failed. ERROR: Execution failed [Reason: ALERT!!:Internal error] : ./updater5.sh (error code = 1) Finished after 13 seconds. Failed Command: //usr/sbin/chromeos-firmwareupdate --mode=autoupdate - Exit Code 1 Firmware update failed (error code: 1). Rolling back update due to failure installing required firmware. Successfully updated GPT with all settings to rollback. PostInstall Failed Did this work before? N/A Chrome version: 70.0.3538.110 Channel: n/a OS Version: 11021.81.0 Flash Version: 31.0.0.148
,
Dec 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/a32c930e8c46424a3bba3c296fd78b3e60f50aeb commit a32c930e8c46424a3bba3c296fd78b3e60f50aeb Author: Hung-Te Lin <hungte@chromium.org> Date: Sat Dec 29 00:14:08 2018 futility: updater: quirks: Support special released SNOW RO A special Snow RO firmware had been released and would break existing platform check: 'Google_Snow_Rev4.2695.128.0'. As a result, we want to bypass platform check in quirk 'daisy_snow_dual_model'. BUG= chromium:917581 TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility BRANCH=None Change-Id: I10b0e4c2b8a11faff979b4add368f342a72a6cec Signed-off-by: Hung-Te Lin <hungte@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1390083 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Joel Kitching <kitching@chromium.org> [modify] https://crrev.com/a32c930e8c46424a3bba3c296fd78b3e60f50aeb/futility/updater.h [modify] https://crrev.com/a32c930e8c46424a3bba3c296fd78b3e60f50aeb/futility/updater.c [modify] https://crrev.com/a32c930e8c46424a3bba3c296fd78b3e60f50aeb/futility/updater_quirks.c
,
Jan 2
,
Jan 2
,
Jan 2
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 2
Has this change been tested and verified? I'm not able to approve the merge for M71 and M72 until there's commentary on verification and a risk assessment. Also, was crbug.com/915013 reviewed to ensure consistency with these findings and the resolution strategy?
,
Jan 2
Tagging this as a P0 RBS for daisy since it's blocking that device from being pushed; resetting the daisy push to 0% for M71 and halting the push for the next stable. Per comments in #8 we need verification and more eyes before we consider M71 merge approval for a stable refresh.
,
Jan 2
crbug.com/915013 is different from crbug.com/917581 . crbug.com/915013 is about FW update successfully, but UI somehow did not reflect it. crbug.com/917581 is real failure on FW update. We also need to verify the solution for sure. Finally, I am wondering what will be happened if we update wrong FW in the future for Daisy x16 device from some reasons?
,
Jan 2
,
Jan 3
I made some simulation but no real device to test (this needs a particular snow x16 with RO=Google_Snow_Rev4.2695.128.0). > what will be happened if we update wrong FW in the future for Daisy x16 device from some reasons? Depends on how "wrong" FW you've deployed. If you install x8 RW FW => system won't boot in norm/dev mode (can boot in recovery mode).
,
Jan 3
The patch provided by hungte only impact Daisy x16 device, rest of devices should not be impacted. We still need verification result before merge approved for M71/M72. Finally, the only concern is: device will boot into recovery mode if wrong FW is deployed for Daisy x16 device (see comment 12). However, that one should be caught by testing/verification before pushing to live.
,
Jan 3
Merge approval pending verification as noted in #13
,
Jan 4
I don't have devices to verify. Anyone can help? @dchan?
,
Jan 7
Can we broaden the net for verification assistance given the timing?
,
Jan 9
Daisy is going to miss the M71 push altogether since we can't get verification and a merge. Escalating to see if anyone can assist with the verification
,
Jan 9
Likely not going to happen given timezones; anyone else in a position to verify?
,
Jan 10
Actually a verified fix that is also merge approved is fine by end-of-day Pacific Thursday. Moving this to a P0 since we're not getting attention on verification and we're likely to skip daisy for M71 otherwise.
,
Jan 10
dchan@ is planning to test today; pending that outcome I'll approve the merge, but we'll need the merge by end-of-day U.S. time.
,
Jan 10
,
Jan 10
Cherry-picks for 71 and 72 are up at: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1405390 https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1405389 R71 had a trivial conflict in the futility/updater.h as FYI.
,
Jan 10
Verified this issue on M73 build Verification steps: 1. Installed M73 build( 11558.0.0) 2. Reinstalled M70 build(11021.81.0). 3. Auto updated to M71 build(11151.111.0). Result: Both X8 & X16 devices are working fine after auto update from M70 to M71.
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/8cc7413dc80a675b40f54f74407d2ae4bce9a1a3 commit 8cc7413dc80a675b40f54f74407d2ae4bce9a1a3 Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Jan 10 19:06:51 2019 futility: updater: quirks: Support special released SNOW RO A special Snow RO firmware had been released and would break existing platform check: 'Google_Snow_Rev4.2695.128.0'. As a result, we want to bypass platform check in quirk 'daisy_snow_dual_model'. BUG= chromium:917581 TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility BRANCH=None Change-Id: I10b0e4c2b8a11faff979b4add368f342a72a6cec Signed-off-by: Hung-Te Lin <hungte@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1390083 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Joel Kitching <kitching@chromium.org> (cherry picked from commit a32c930e8c46424a3bba3c296fd78b3e60f50aeb) Reviewed-on: https://chromium-review.googlesource.com/c/1405389 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Commit-Queue: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/8cc7413dc80a675b40f54f74407d2ae4bce9a1a3/futility/updater.h [modify] https://crrev.com/8cc7413dc80a675b40f54f74407d2ae4bce9a1a3/futility/updater.c [modify] https://crrev.com/8cc7413dc80a675b40f54f74407d2ae4bce9a1a3/futility/updater_quirks.c
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/205dd51998cdfcef0971f4ab644c179f2eca4bee commit 205dd51998cdfcef0971f4ab644c179f2eca4bee Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Jan 10 19:06:53 2019 futility: updater: quirks: Support special released SNOW RO A special Snow RO firmware had been released and would break existing platform check: 'Google_Snow_Rev4.2695.128.0'. As a result, we want to bypass platform check in quirk 'daisy_snow_dual_model'. BUG= chromium:917581 TEST=make futil; tests/futility/run_test_scripts.sh $(pwd)/build/futility BRANCH=None Change-Id: I10b0e4c2b8a11faff979b4add368f342a72a6cec Signed-off-by: Hung-Te Lin <hungte@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1390083 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Joel Kitching <kitching@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1405390 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Commit-Queue: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/205dd51998cdfcef0971f4ab644c179f2eca4bee/futility/updater.h [modify] https://crrev.com/205dd51998cdfcef0971f4ab644c179f2eca4bee/futility/updater.c [modify] https://crrev.com/205dd51998cdfcef0971f4ab644c179f2eca4bee/futility/updater_quirks.c
,
Jan 10
Approving merge for m71 and M72 Chrome OS (coordinated with bhthompson@ prior to the merge).
,
Jan 11
Both CL merged by Bernie. Close as fixed.
,
Jan 14
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 14
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by hungte@chromium.org
, Dec 24Status: Assigned (was: Unconfirmed)