Remove use of base::TestMockTimeTaskRunner in cros power/ml unit tests |
||
Issue descriptionbase::TestMockTimeTaskRunner is no longer needed and the RenderViewHostTestHarness' thread bundle (which now inherits from base::ScopedTaskEnvironment) can be used as a mock time task runner whose time/execution can be controlled.
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a74620f6be047ad953d494b2fd89b7c93553d0a commit 1a74620f6be047ad953d494b2fd89b7c93553d0a Author: Prashant Malani <pmalani@chromium.org> Date: Fri Jan 04 03:36:14 2019 [Power: ML]: Remove remaining uses of TestMockTimeTaskRunner ScopedTaskEnvironment is sufficient for the purposes of power/ml unit tests, so remove usages of TestMockTimeTaskRunner. This also removes need to support both TestMockTimeTaskRunner *and* ScopedTaskEnvironment in FakeBookClock. Bug: 917580 Test: All related unit tests still pass. Change-Id: Iec413bf52422a12462f8ff99ef5e02e23907925a Reviewed-on: https://chromium-review.googlesource.com/c/1393896 Reviewed-by: Jia Meng <jiameng@chromium.org> Commit-Queue: Prashant Malani <pmalani@chromium.org> Cr-Commit-Position: refs/heads/master@{#619877} [modify] https://crrev.com/1a74620f6be047ad953d494b2fd89b7c93553d0a/chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager_unittest.cc [modify] https://crrev.com/1a74620f6be047ad953d494b2fd89b7c93553d0a/chrome/browser/chromeos/power/ml/fake_boot_clock.cc [modify] https://crrev.com/1a74620f6be047ad953d494b2fd89b7c93553d0a/chrome/browser/chromeos/power/ml/fake_boot_clock.h [modify] https://crrev.com/1a74620f6be047ad953d494b2fd89b7c93553d0a/chrome/browser/chromeos/power/ml/idle_event_notifier_unittest.cc
,
Jan 4
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jan 2