New issue
Advanced search Search tips

Issue 917580 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove use of base::TestMockTimeTaskRunner in cros power/ml unit tests

Project Member Reported by pmalani@chromium.org, Dec 22

Issue description

base::TestMockTimeTaskRunner is no longer needed and the RenderViewHostTestHarness' thread bundle (which now inherits from base::ScopedTaskEnvironment) can be used as a mock time task runner whose time/execution can be controlled.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c1844467ad9e40e0a7ab242c8a09beeb4e998f

commit a0c1844467ad9e40e0a7ab242c8a09beeb4e998f
Author: Prashant Malani <pmalani@chromium.org>
Date: Wed Jan 02 22:12:35 2019

Add RenderViewHostTestHarness ctor for thread bundle

Add a new constructor for RenderViewHostTestHarness (and its derived
class ChromeRenderViewHostTestHarness) to include
ScopedTaskEnvironment parameters. This will allow the test harness
classes to use the ScopedTaskEnvironment's task runner for mock time
task runners, instead of instantiating a separate
TestMockTimeTaskRunner.

This CL also modifies the UserActivityManagerTest unit tests to leverage
this in-built ScopedTaskEnvironment and remove the mock time task
runner, and also makes the FakeSmartDimModel implementation utilize the
task runner for posting tasks, to better mimick real-world behaviour.

Bug: 893425,  914640 ,  917580 
Test: - Builds and boots, inference calls checked via logs on nocturne
      - All related unit tests still pass.

Change-Id: I552ae98f6b2bce88845d17648303001a3c644788
Reviewed-on: https://chromium-review.googlesource.com/c/1389963
Commit-Queue: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619512}
[modify] https://crrev.com/a0c1844467ad9e40e0a7ab242c8a09beeb4e998f/chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager_unittest.cc
[modify] https://crrev.com/a0c1844467ad9e40e0a7ab242c8a09beeb4e998f/chrome/browser/chromeos/power/ml/fake_boot_clock.cc
[modify] https://crrev.com/a0c1844467ad9e40e0a7ab242c8a09beeb4e998f/chrome/browser/chromeos/power/ml/fake_boot_clock.h
[modify] https://crrev.com/a0c1844467ad9e40e0a7ab242c8a09beeb4e998f/chrome/browser/chromeos/power/ml/user_activity_manager_unittest.cc
[modify] https://crrev.com/a0c1844467ad9e40e0a7ab242c8a09beeb4e998f/chrome/test/base/chrome_render_view_host_test_harness.cc
[modify] https://crrev.com/a0c1844467ad9e40e0a7ab242c8a09beeb4e998f/chrome/test/base/chrome_render_view_host_test_harness.h
[modify] https://crrev.com/a0c1844467ad9e40e0a7ab242c8a09beeb4e998f/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/a0c1844467ad9e40e0a7ab242c8a09beeb4e998f/content/public/test/test_renderer_host.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a74620f6be047ad953d494b2fd89b7c93553d0a

commit 1a74620f6be047ad953d494b2fd89b7c93553d0a
Author: Prashant Malani <pmalani@chromium.org>
Date: Fri Jan 04 03:36:14 2019

[Power: ML]: Remove remaining uses of TestMockTimeTaskRunner

ScopedTaskEnvironment is sufficient for the purposes of power/ml
unit tests, so remove usages of TestMockTimeTaskRunner. This also
removes need to support both TestMockTimeTaskRunner *and*
ScopedTaskEnvironment in FakeBookClock.

Bug:  917580 
Test: All related unit tests still pass.

Change-Id: Iec413bf52422a12462f8ff99ef5e02e23907925a
Reviewed-on: https://chromium-review.googlesource.com/c/1393896
Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Prashant Malani <pmalani@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619877}
[modify] https://crrev.com/1a74620f6be047ad953d494b2fd89b7c93553d0a/chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager_unittest.cc
[modify] https://crrev.com/1a74620f6be047ad953d494b2fd89b7c93553d0a/chrome/browser/chromeos/power/ml/fake_boot_clock.cc
[modify] https://crrev.com/1a74620f6be047ad953d494b2fd89b7c93553d0a/chrome/browser/chromeos/power/ml/fake_boot_clock.h
[modify] https://crrev.com/1a74620f6be047ad953d494b2fd89b7c93553d0a/chrome/browser/chromeos/power/ml/idle_event_notifier_unittest.cc

Status: Verified (was: Untriaged)

Sign in to add a comment