Android Messages integration in ChromeOS has references to both staging and production urls with a flag controlling which one to be used https://cs.chromium.org/chromium/src/chrome/browser/chromeos/android_sms/android_sms_urls.cc?rcl=20e2e36f0d46869b499d208e52a9de6c66c17b27&l=22. Since production roll out is already complete for Messages for Web, the staging url reference and the flag used to control this should be removed. The GetAndroidMessagesURLWithParams function should also be removed since this functionality is now enabled through cookies.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1 commit 85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1 Author: Azeem Arshad <azeemarshad@chromium.org> Date: Thu Dec 27 20:02:43 2018 [AndroidSms] Cleanup android messages urls This CL removes Messages for Web staging URL and flag that controls it. This also removes the GetAndroidMessagesURLWithParams function that's used in the Messages PWA installation. This function is not required anymore since the DefaultToPersist flag is now set as a cookie. Bug: 917543 Change-Id: I6f37217487cf5d7b875adedfe1506ef671d8f720 Reviewed-on: https://chromium-review.googlesource.com/c/1389495 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#619060} [modify] https://crrev.com/85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1/chrome/browser/about_flags.cc [modify] https://crrev.com/85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1/chrome/browser/chromeos/android_sms/android_sms_urls.cc [modify] https://crrev.com/85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1/chrome/browser/chromeos/android_sms/android_sms_urls.h [modify] https://crrev.com/85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc [modify] https://crrev.com/85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl_unittest.cc [modify] https://crrev.com/85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1/chrome/browser/flag-metadata.json [modify] https://crrev.com/85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1/chrome/browser/flag_descriptions.h [modify] https://crrev.com/85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1/chromeos/chromeos_features.cc [modify] https://crrev.com/85fd3fb7abed2eaca8310f57cd55ee17ffa3cfd1/chromeos/chromeos_features.h
Comment 1 by azeemarshad@chromium.org
, Dec 22