New issue
Advanced search Search tips

Issue 917541 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 28
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Flaky-Test: fast/peerconnection/RTCPeerConnection-remote-applyConstraints.html



Sign in to add a comment

fast/peerconnection/RTCPeerConnection-remote-applyConstraints.html is flaky

Project Member Reported by Findit, Dec 22

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20e2e36f0d46869b499d208e52a9de6c66c17b27

commit 20e2e36f0d46869b499d208e52a9de6c66c17b27
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sat Dec 22 00:15:53 2018

Revert "Apply constraints for remote video tracks."

This reverts commit c3136103101141dfa259ae64294e18e46727ba01.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 618630 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYzMxMzYxMDMxMDExNDFkZmEyNTlhZTY0Mjk0ZTE4ZTQ2NzI3YmEwMQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20Leak/27794

Sample Failed Step: webkit_layout_tests

Sample Flaky Test: fast/peerconnection/RTCPeerConnection-remote-applyConstraints.html

Original change's description:
> Apply constraints for remote video tracks.
> 
> Bug:  899789 
> Change-Id: I28f538888f1bd041ffa31cc650d19245228e044f
> Reviewed-on: https://chromium-review.googlesource.com/c/1388436
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618630}

Change-Id: I16a38cb267e3c18f636098bec9f8c58dcd951a59
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  899789 ,  917541 
Reviewed-on: https://chromium-review.googlesource.com/c/1389438
Cr-Commit-Position: refs/heads/master@{#618686}
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/apply_constraints_processor.cc
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/media_stream_types.h
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/media_stream_video_source.cc
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/media_stream_video_source.h
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/media_stream_video_track.cc
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/media_stream_video_track.h
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/video_track_adapter.cc
[modify] https://crrev.com/20e2e36f0d46869b499d208e52a9de6c66c17b27/content/renderer/media/stream/video_track_adapter.h
[delete] https://crrev.com/3783894ab6b33d5112d834e43e8c06ad93a2dc09/third_party/blink/web_tests/fast/peerconnection/RTCPeerConnection-remote-applyConstraints.html

As FindIt reverted the CL, removing Sheriff-Chromium label, nothing to do here from a sheriffing perspective at the moment.
Labels: -Pri-1 -Sheriff-Chromium Pri-2
Status: Fixed (was: Untriaged)
I think we can just close this CL since the original issue can track the revert.

Sign in to add a comment