New issue
Advanced search Search tips

Issue 917483 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Abrt in blink::ReportFatalErrorInMainThread

Project Member Reported by ClusterFuzz, Dec 21

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5706243087532032

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x053900000001
Crash State:
  blink::ReportFatalErrorInMainThread
  v8::Utils::ReportApiFailure
  v8::internal::HandleScope::Extend
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=615479:615480

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5706243087532032

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.
 
Project Member

Comment 1 by ClusterFuzz, Dec 21

Components: Blink>Bindings Blink>JavaScript
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 21

Labels: Test-Predator-Auto-Owner
Owner: yukishiino@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/0d557dedf31c8cf30bee794ea983b5a16f899b0e (v8binding: Do not hold a cross origin ScriptState in IDL callback interface).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/438e9a1b221bf9477569521c9aabfd2102e93ead

commit 438e9a1b221bf9477569521c9aabfd2102e93ead
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Fri Dec 28 02:44:13 2018

v8binding: Fix crash issue at IDL callback interface/function

1. When throwing an exception, we need to enter v8::HandleScope.

2. In fullscreen.cc, ScriptState::Scope requires the ScriptState's
context is valid.

Bug:  917483 
Change-Id: Ieade2c8a0241bea21d9a82bb138020f448a69c8c
Reviewed-on: https://chromium-review.googlesource.com/c/1390893
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619108}
[modify] https://crrev.com/438e9a1b221bf9477569521c9aabfd2102e93ead/third_party/blink/renderer/core/fullscreen/fullscreen.cc
[modify] https://crrev.com/438e9a1b221bf9477569521c9aabfd2102e93ead/third_party/blink/renderer/platform/bindings/callback_function_base.cc
[modify] https://crrev.com/438e9a1b221bf9477569521c9aabfd2102e93ead/third_party/blink/renderer/platform/bindings/callback_interface_base.cc

Status: Fixed (was: Started)
Project Member

Comment 6 by ClusterFuzz, Dec 28

ClusterFuzz has detected this issue as fixed in range 619107:619108.

Detailed report: https://clusterfuzz.com/testcase?key=5706243087532032

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x053900000001
Crash State:
  blink::ReportFatalErrorInMainThread
  v8::Utils::ReportApiFailure
  v8::internal::HandleScope::Extend
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=615479:615480
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=619107:619108

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5706243087532032

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Dec 28

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5706243087532032 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment