New issue
Advanced search Search tips

Issue 917467 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

WebApkIntegrationTest#testLaunchAndNavigateOffOrigin failing with network service enabled

Project Member Reported by cduvall@chromium.org, Dec 21

Issue description

http://crrev.com/c/1378816 introduced MockCertVerifierRuleAndroid, which uses ChromeMockCertVerifier. It looks like base::FeatureList is not being initialized before methods on ChromeMockCertVerifier are called, which check base::FeatureList to see if network service is enabled[1,2].

Example failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Android/11665

1. https://cs.chromium.org/chromium/src/content/public/test/content_mock_cert_verifier.cc?l=30&rcl=97e6cbbcb0071b5db924187dd6bb1ea4de129f96
2. https://cs.chromium.org/chromium/src/content/public/test/content_mock_cert_verifier.cc?l=99&rcl=97e6cbbcb0071b5db924187dd6bb1ea4de129f96
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44c80f25b7ac828337959e639ae88d1bcc27903f

commit 44c80f25b7ac828337959e639ae88d1bcc27903f
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Dec 21 20:55:22 2018

Disable failing WebApkIntegrationTest#testLaunchAndNavigateOffOrigin on NS

This test began failing on the network service bot after
http://crrev.com/c/1378816

TBR=pkotwicz@chromium.org

Bug: 917467
Change-Id: If515c9221712ca89b71dcd82994849fbba22736f
Reviewed-on: https://chromium-review.googlesource.com/c/1388113
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618591}
[modify] https://crrev.com/44c80f25b7ac828337959e639ae88d1bcc27903f/testing/buildbot/filters/mojo.fyi.network_chrome_public_test_apk.filter

Labels: Hotlist-KnownIssue
Owner: cduvall@chromium.org
Status: Assigned (was: Available)
can you take a look?

Comment 3 by pkotw...@chromium.org, Jan 17 (6 days ago)

cduvall@ do you have any ideas?

I looked into this failure for the past two days
- The feature list issue can be fixed by loading the browser process via NativeLibraryTestRule#loadNativeLibraryAndInitBrowserProcess()
- NativeLibraryTestRule#loadNativeLibraryAndInitBrowserProcess() must be called after starting the EmbeddedTestServer

However, I have not been able to get the test to work.

I get the following check/dcheck failures:

DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
service_manager::Connector::BindConnectorIfNecessary()                                                                                                                                                                                                                                                                                                  ../../services/service_manager/public/cpp/connector.cc:152:3
content::ContentMockCertVerifier::CertVerifier::EnsureNetworkServiceTestInitialized()                                                                                                                                                                                                                                                                   ../../content/public/test/content_mock_cert_verifier.cc:75:64
content::ContentMockCertVerifier::CertVerifier::set_default_result(int)                    

CHECK(ThreadTaskRunnerHandle::IsSet())
base::SequencedTaskRunnerHandle::Get()                                                                                                                                                                                                        ../../base/threading/sequenced_task_runner_handle.cc:33:3                                                                                   
content::ContentMockCertVerifier::CertVerifier::EnsureNetworkServiceTestInitialized()                                                                                                                                                         ../../content/public/test/content_mock_cert_verifier.cc:75:64
content::ContentMockCertVerifier::CertVerifier::set_default_result(int)                                                                                                                                                                       ../../content/public/test/content_mock_cert_verifier.cc:38:3
Java_org_chromium_chrome_browser_test_MockCertVerifierRuleAndroid_nativeSetUp                                                                                                                                                                 gen/chrome/android/test_support_jni_headers/test_support_jni_headers/jni/MockCertVerifierRuleAndroid_jni.h:60:18

These are the changes that I tried:
https://chromium-review.googlesource.com/c/chromium/src/+/1416977
The WebApkIntegration tests are special because they ContentMockCertVerifier from a javatest instead of from an inprocess_browser_test.

Here is what I tried https://chromium-review.googlesource.com/c/chromium/src/+/1416977
(I also tried combinations similar to the CL)

Sign in to add a comment