WebApkIntegrationTest#testLaunchAndNavigateOffOrigin failing with network service enabled |
||
Issue descriptionhttp://crrev.com/c/1378816 introduced MockCertVerifierRuleAndroid, which uses ChromeMockCertVerifier. It looks like base::FeatureList is not being initialized before methods on ChromeMockCertVerifier are called, which check base::FeatureList to see if network service is enabled[1,2]. Example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Android/11665 1. https://cs.chromium.org/chromium/src/content/public/test/content_mock_cert_verifier.cc?l=30&rcl=97e6cbbcb0071b5db924187dd6bb1ea4de129f96 2. https://cs.chromium.org/chromium/src/content/public/test/content_mock_cert_verifier.cc?l=99&rcl=97e6cbbcb0071b5db924187dd6bb1ea4de129f96
,
Jan 15
can you take a look?
,
Jan 17
(6 days ago)
cduvall@ do you have any ideas? I looked into this failure for the past two days - The feature list issue can be fixed by loading the browser process via NativeLibraryTestRule#loadNativeLibraryAndInitBrowserProcess() - NativeLibraryTestRule#loadNativeLibraryAndInitBrowserProcess() must be called after starting the EmbeddedTestServer However, I have not been able to get the test to work. I get the following check/dcheck failures: DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); service_manager::Connector::BindConnectorIfNecessary() ../../services/service_manager/public/cpp/connector.cc:152:3 content::ContentMockCertVerifier::CertVerifier::EnsureNetworkServiceTestInitialized() ../../content/public/test/content_mock_cert_verifier.cc:75:64 content::ContentMockCertVerifier::CertVerifier::set_default_result(int) CHECK(ThreadTaskRunnerHandle::IsSet()) base::SequencedTaskRunnerHandle::Get() ../../base/threading/sequenced_task_runner_handle.cc:33:3 content::ContentMockCertVerifier::CertVerifier::EnsureNetworkServiceTestInitialized() ../../content/public/test/content_mock_cert_verifier.cc:75:64 content::ContentMockCertVerifier::CertVerifier::set_default_result(int) ../../content/public/test/content_mock_cert_verifier.cc:38:3 Java_org_chromium_chrome_browser_test_MockCertVerifierRuleAndroid_nativeSetUp gen/chrome/android/test_support_jni_headers/test_support_jni_headers/jni/MockCertVerifierRuleAndroid_jni.h:60:18 These are the changes that I tried: https://chromium-review.googlesource.com/c/chromium/src/+/1416977 The WebApkIntegration tests are special because they ContentMockCertVerifier from a javatest instead of from an inprocess_browser_test. Here is what I tried https://chromium-review.googlesource.com/c/chromium/src/+/1416977 (I also tried combinations similar to the CL) |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Dec 21