New issue
Advanced search Search tips

Issue 917446 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Stop putting binary files in $root_gen_dir

Project Member Reported by agrieve@chromium.org, Dec 21

Issue description

We've now got some guidelines about where to put intermediate files:
https://chromium.googlesource.com/chromium/src/+/HEAD/build/docs/writing_gn_templates.md#where-to-place-outputs

However, in many spots we're not following them.

Here are most files in my gen/ directly that should be in obj/. Found via:
    for f in $(find -type f); do file $f --mime-encoding | grep binary > /dev/null && echo $f; done > all.txt

$OUT/gen/arsc/*.ap_
$OUT/gen/arsc/apks/*.ap_
$OUT/gen/*/*.javac.jar
$OUT/gen/*/*.javac.jar.pdb
$OUT/gen/*/*.dex.jar
$OUT/gen/ui/strings/*.pak
$OUT/gen/remoting/resources/*.pak
$OUT/gen/ui/resources/ui_resources_100_percent.pak
$OUT/gen/ui/resources/webui_resources_grd_stamp.d.stamp
$OUT/gen/ui/gl/surface_jni_headers/ui/gl/jni/android/view/Surface.class
$OUT/gen/components/ui_devtools/__jinja2_*.cache
$OUT/gen/components/autofill_assistant/browser/devtools/__jinja2_7eba5c627b33dd475c048c3a2562892c45ddfebf.cache
$OUT/gen/components/resources/about_credits.bro
$OUT/gen/third_party/blink/renderer/core/inspector/protocol.json.bro
$OUT/gen/net/android/net_test_support_apk/net_test_support_apk.interface.jar
$OUT/gen/net/android/net_test_support_apk/classes.dex.zip
$OUT/gen/net/android/net_test_support_apk/net_test_support_apk.jar
$OUT/gen/sun_tools_jar/tools.jar
$OUT/gen/v8/*.bin
$OUT/gen/mojo/public/tools/bindings/java_templates.zip
$OUT/gen/chrome/test/data/media/engagement/preload/empty.pb


Not sure about:
$OUT/gen/*/*.v
 * These are all empty files. Create by: https://cs.chromium.org/chromium/src/mojo/public/tools/bindings/mojom.gni
$OUT/gen/*/*.p
 * These are plain text, but also gibberish. Create by: https://cs.chromium.org/chromium/src/mojo/public/tools/bindings/mojom.gni
$OUT/gen/third_party/gvr-android-sdk/gvr_common_java/classes.jar
 * These are created by extracting .aar files
 * Most files are binary, but some (AndroidManifest.xml, res/*.xml) are not.


Note: I'm not unsure if there are any actual consequences to having so many binary files under "gen".
 * One is that it takes longer to "grep" the directory.
 

Sign in to add a comment