New issue
Advanced search Search tips

Issue 917419 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 917351
issue 919083
issue 919262
issue 919922

Blocking:
issue 916828
issue webrtc:10165
issue 893437
issue 919761



Sign in to add a comment

roll clang again

Project Member Reported by thakis@chromium.org, Dec 21

Issue description

Previous roll:   Issue 904337  
 
ToTLinuxASanLibfuzzer seems to be broken for a week: the first breakage is quite confusing: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTLinuxASanLibfuzzer/1560

[268/3798] Building CXX object lib/TextAPI/CMakeFiles/LLVMTextAPI.dir/MachO/TextStub.cpp.o
FAILED: lib/TextAPI/CMakeFiles/LLVMTextAPI.dir/MachO/TextStub.cpp.o 
/usr/bin/c++  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/TextAPI -I/b/s/w/ir/cache/builder/src/third_party/llvm/lib/TextAPI -I/usr/include/libxml2 -Iinclude -I/b/s/w/ir/cache/builder/src/third_party/llvm/include -DLLVM_FORCE_HEAD_REVISION -fPIC -fvisibility-inlines-hidden -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-sections -O3    -UNDEBUG  -fno-exceptions -fno-rtti -MD -MT lib/TextAPI/CMakeFiles/LLVMTextAPI.dir/MachO/TextStub.cpp.o -MF lib/TextAPI/CMakeFiles/LLVMTextAPI.dir/MachO/TextStub.cpp.o.d -o lib/TextAPI/CMakeFiles/LLVMTextAPI.dir/MachO/TextStub.cpp.o -c /b/s/w/ir/cache/builder/src/third_party/llvm/lib/TextAPI/MachO/TextStub.cpp
/b/s/w/ir/cache/builder/src/third_party/llvm/lib/TextAPI/MachO/TextStub.cpp: In static member function 'static llvm::Expected<std::unique_ptr<llvm::MachO::InterfaceFile> > llvm::MachO::TextAPIReader::get(std::unique_ptr<llvm::MemoryBuffer>)':
/b/s/w/ir/cache/builder/src/third_party/llvm/lib/TextAPI/MachO/TextStub.cpp:643:10: error: could not convert 'File' from 'std::unique_ptr<llvm::MachO::InterfaceFile>' to 'llvm::Expected<std::unique_ptr<llvm::MachO::InterfaceFile> >'
   return File;
          ^
/b/s/w/ir/cache/builder/src/third_party/llvm/lib/TextAPI/MachO/TextStub.cpp:644:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
[269/3798] Building CXX object lib/Option/CMakeFiles/LLVMOption.dir/Arg.cpp.o


But now there is another one: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTLinuxASanLibfuzzer/1649

[934/982] Building CXX object lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profile_collector.cc.o
FAILED: lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profile_collector.cc.o 
/usr/bin/c++  -DXRAY_HAS_EXCEPTIONS=1 -I/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/.. -I/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/../../include -DLLVM_FORCE_HEAD_REVISION -Wall -std=c++11 -Wno-unused-parameter -O3 -DNDEBUG    -m64 -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fvisibility=hidden -fno-lto -O3 -g -Wno-variadic-macros -Wno-non-virtual-dtor -fno-rtti -MD -MT lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profile_collector.cc.o -MF lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profile_collector.cc.o.d -o lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profile_collector.cc.o -c /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_profile_collector.cc
In file included from /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_function_call_trie.h:20:0,
                 from /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_profile_collector.h:21,
                 from /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_profile_collector.cc:15:
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_segmented_array.h: In instantiation of 'T* __xray::Array<T>::AppendEmplace(Args&& ...) [with Args = {const __xray::profileCollectorService::{anonymous}::ThreadTrie&}; T = __xray::profileCollectorService::{anonymous}::ThreadTrie]':
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_segmented_array.h:383:71:   required from 'T* __xray::Array<T>::Append(const T&) [with T = __xray::profileCollectorService::{anonymous}::ThreadTrie]'
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_profile_collector.cc:98:34:   required from here
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_segmented_array.h:378:5: error: could not convert '{std::forward<const __xray::profileCollectorService::{anonymous}::ThreadTrie&>((* & args#0))}' from '<brace-enclosed initializer list>' to '__xray::profileCollectorService::{anonymous}::ThreadTrie'
     new (AlignedOffset) T{std::forward<Args>(args)...};
     ^
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_segmented_array.h: In instantiation of 'T* __xray::Array<T>::AppendEmplace(Args&& ...) [with Args = {const __xray::profileCollectorService::{anonymous}::ProfileBuffer&}; T = __xray::profileCollectorService::{anonymous}::ProfileBuffer]':
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_segmented_array.h:383:71:   required from 'T* __xray::Array<T>::Append(const T&) [with T = __xray::profileCollectorService::{anonymous}::ProfileBuffer]'
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_profile_collector.cc:244:44:   required from here
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/xray/xray_segmented_array.h:378:5: error: could not convert '{std::forward<const __xray::profileCollectorService::{anonymous}::ProfileBuffer&>((* & args#0))}' from '<brace-enclosed initializer list>' to '__xray::profileCollectorService::{anonymous}::ProfileBuffer'


None of these seems to be ASan / libFuzzer specific, though other bots (e.g. Coverage: https://ci.chromium.org/buildbot/chromium.clang/ToTLinuxCoverage/) seem to work better.
Can you file a separate bug for that and mark this one blocked on that?
I definitely can, but apparently the bot is green now, making my yesterday's effort useless :)

Blocking: webrtc:10165
Want rL350251 for webrtc:10165
Blockedon: 917351
Cc: p...@chromium.org
I gave building packages a try at https://chromium-review.googlesource.com/c/chromium/src/+/1394732

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_upload_clang/387 has been at it for 1.5h already; it's usually done in < 1h. It's hanging while linking lld, which I think uses LTO. I'm guessing LTO perf has regressed upstream.
Blockedon: 919083
Filed  issue 919083  for linking of lld timing out.
Want r350445 for issue 916828.
Blocking: 916828
Blockedon: 919262
Blockedon: 919922
Blocking: 919761
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54a0c3d18cced2cfe0a32edec204de840f80d596

commit 54a0c3d18cced2cfe0a32edec204de840f80d596
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jan 11 02:18:50 2019

Roll clang 349417:350768.

Ran `tools/clang/scripts/upload_revision.py 350768`.

Bug:  917419 
Change-Id: Id45d0e418634fb0c4e796626c364b3bd47c60829
Reviewed-on: https://chromium-review.googlesource.com/c/1404702
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621872}
[modify] https://crrev.com/54a0c3d18cced2cfe0a32edec204de840f80d596/tools/clang/scripts/update.py

Comment 17 by h...@chromium.org, Jan 16 (6 days ago)

Owner: thakis@chromium.org
Status: Fixed (was: Untriaged)
Next roll:  Issue 922384 

Comment 18 by thakis@chromium.org, Jan 17 (5 days ago)

Blocking: 893437

Sign in to add a comment