New issue
Advanced search Search tips

Issue 917417 link

Starred by 2 users
Status: Assigned
Owner:
torne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocking:
issue 887078



Sign in to add a comment

Clean up MonochromeApplication for Trichrome

Project Member Reported by torne@chromium.org, Dec 21 
Trichrome currently uses MonochromeApplication to avoid weird crashes during initialisation that happen if you use ChromeApplication (though only on the downstream build).

We need to look into what MonochromeApplication is actually doing and see which things are actually specific to Monochrome in a meaningful way (e.g. using webview library preloading) vs which things might be better in ChromeApplication behind an SDK level check as they are actually just related to Monochrome's minsdk level.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3810e0dfbc73bd5b01f47d71aa1ef3fb931f1365

commit 3810e0dfbc73bd5b01f47d71aa1ef3fb931f1365
Author: Torne (Richard Coles) <torne@google.com>
Date: Fri Dec 21 20:26:41 2018

Use MonochromeApplication for Trichrome.

MonochromeApplication does various initialisation that isn't directly
related to being a WebView implementation and in some cases it appears
to be necessary for Trichrome to work properly, though it's unclear why.

Just have Trichrome reuse the Monochrome one for now - the library
loading part won't work but only logs a warning when it fails, so it's
not a blocker.

Bug: 917417
Change-Id: I593e7414c7d2acf200f96aad60fa3bf8d95bbdca
Reviewed-on: https://chromium-review.googlesource.com/c/1383133
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618581}
[modify] https://crrev.com/3810e0dfbc73bd5b01f47d71aa1ef3fb931f1365/chrome/android/java/AndroidManifest_trichrome_chrome.xml

Comment 2 by sbash...@chromium.org, Jan 7 

Please add manual verification steps if applicable for M73 .Thanks
►

Sign in to add a comment