Split credit cards in 2 sections (local, from account) in the settings page |
|||
Issue descriptionThe cards should be listed depending on where they are stored. Local copy of server cards should be shown in both.
,
Jan 9
Code is pretty much done, I'm just waiting on a confirmation for the strings.
,
Jan 16
(6 days ago)
Here is a link to the mock for the new settings page: https://docs.google.com/presentation/d/1Lc_IU7ERiu8iPB0o3WT5ah8Xa1D_EpCQn-zgKMZKsls/edit#slide=id.g49730fc023_0_112
,
Jan 16
(6 days ago)
This is a before screenshot
,
Jan 16
(6 days ago)
,
Jan 17
(6 days ago)
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48d53acd9f3ad6a628e4422a0d63024cfbbebcd5 commit 48d53acd9f3ad6a628e4422a0d63024cfbbebcd5 Author: sebsg <sebsg@chromium.org> Date: Thu Jan 17 18:11:16 2019 [AF] Add feature and flag for the payments settings page split. Bug: 917396 Change-Id: I46e93d31525e525719d3e5a14ee071113f41dae7 Reviewed-on: https://chromium-review.googlesource.com/c/1417355 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#623749} [modify] https://crrev.com/48d53acd9f3ad6a628e4422a0d63024cfbbebcd5/chrome/browser/about_flags.cc [modify] https://crrev.com/48d53acd9f3ad6a628e4422a0d63024cfbbebcd5/chrome/browser/flag-metadata.json [modify] https://crrev.com/48d53acd9f3ad6a628e4422a0d63024cfbbebcd5/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/48d53acd9f3ad6a628e4422a0d63024cfbbebcd5/chrome/browser/flag_descriptions.h [modify] https://crrev.com/48d53acd9f3ad6a628e4422a0d63024cfbbebcd5/components/autofill/core/common/autofill_features.cc [modify] https://crrev.com/48d53acd9f3ad6a628e4422a0d63024cfbbebcd5/components/autofill/core/common/autofill_features.h [modify] https://crrev.com/48d53acd9f3ad6a628e4422a0d63024cfbbebcd5/tools/metrics/histograms/enums.xml
,
Jan 18
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/469448bd91ab508433373a88edabbcd9e51057bc commit 469448bd91ab508433373a88edabbcd9e51057bc Author: sebsg <sebsg@chromium.org> Date: Fri Jan 18 00:36:57 2019 [AF] Record card/address viewed user action in js instead of c++. In C++ it was recorded everytime the cards or addresses were loaded, which is not necessarily only when the settings page gets open. This will also allow to more easily log with the split payments settings page. Bug: 917396 Change-Id: I2f22a38240ac484f8d677e959b0da7aa33fa7975 Reviewed-on: https://chromium-review.googlesource.com/c/1419259 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#623928} [modify] https://crrev.com/469448bd91ab508433373a88edabbcd9e51057bc/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc [modify] https://crrev.com/469448bd91ab508433373a88edabbcd9e51057bc/chrome/browser/resources/settings/autofill_page/autofill_section.js [modify] https://crrev.com/469448bd91ab508433373a88edabbcd9e51057bc/chrome/browser/resources/settings/autofill_page/payments_section.js
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0d40506dc658a111ff79e50a1b2e3f7d9e3ce4c commit a0d40506dc658a111ff79e50a1b2e3f7d9e3ce4c Author: sebsg <sebsg@chromium.org> Date: Fri Jan 18 16:31:29 2019 [AF] Add new strings for the split payments settings page. Adds the title of the two sections: On this device In your Google Account Bug: 917396 Change-Id: I1d92f40264b1688e32a3a0cbcd81eb29af0b2a1e Reviewed-on: https://chromium-review.googlesource.com/c/1418075 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#624154} [modify] https://crrev.com/a0d40506dc658a111ff79e50a1b2e3f7d9e3ce4c/components/autofill_strings.grdp |
|||
►
Sign in to add a comment |
|||
Comment 1 by mastiz@google.com
, Jan 9