New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 917396 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Feature



Sign in to add a comment

Split credit cards in 2 sections (local, from account) in the settings page

Project Member Reported by se...@chromium.org, Dec 21

Issue description

The cards should be listed depending on where they are stored. Local copy of server cards should be shown in both.
 
Triage ping for sebsg@: is there a status update? Thx!
Code is pretty much done, I'm just waiting on a confirmation for the strings.

Comment 4 by se...@chromium.org, Jan 16 (6 days ago)

This is a before screenshot
settings_before_cleaned.png
86.5 KB View Download

Comment 5 by se...@chromium.org, Jan 16 (6 days ago)

Cc: dpa...@chromium.org

Comment 6 by dpa...@chromium.org, Jan 17 (6 days ago)

Labels: -Type-Bug Type-Feature
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/469448bd91ab508433373a88edabbcd9e51057bc

commit 469448bd91ab508433373a88edabbcd9e51057bc
Author: sebsg <sebsg@chromium.org>
Date: Fri Jan 18 00:36:57 2019

[AF] Record card/address viewed user action in js instead of c++.

In C++ it was recorded everytime the cards or addresses were loaded,
which is not necessarily only when the settings page gets open.

This will also allow to more easily log with the split payments
settings page.

Bug: 917396
Change-Id: I2f22a38240ac484f8d677e959b0da7aa33fa7975
Reviewed-on: https://chromium-review.googlesource.com/c/1419259
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623928}
[modify] https://crrev.com/469448bd91ab508433373a88edabbcd9e51057bc/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
[modify] https://crrev.com/469448bd91ab508433373a88edabbcd9e51057bc/chrome/browser/resources/settings/autofill_page/autofill_section.js
[modify] https://crrev.com/469448bd91ab508433373a88edabbcd9e51057bc/chrome/browser/resources/settings/autofill_page/payments_section.js

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0d40506dc658a111ff79e50a1b2e3f7d9e3ce4c

commit a0d40506dc658a111ff79e50a1b2e3f7d9e3ce4c
Author: sebsg <sebsg@chromium.org>
Date: Fri Jan 18 16:31:29 2019

[AF] Add new strings for the split payments settings page.

Adds the title of the two sections:
On this device
In your Google Account

Bug: 917396
Change-Id: I1d92f40264b1688e32a3a0cbcd81eb29af0b2a1e
Reviewed-on: https://chromium-review.googlesource.com/c/1418075
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624154}
[modify] https://crrev.com/a0d40506dc658a111ff79e50a1b2e3f7d9e3ce4c/components/autofill_strings.grdp

Sign in to add a comment