New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 917384 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Background Fetch's UpdateUI not always updating icon

Project Member Reported by rayankans@chromium.org, Dec 21

Issue description

There is a race condition between clearing the job details and offline items asking for the visuals.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30cd990cecc03b0e52cc888fa1c0833816508d32

commit 30cd990cecc03b0e52cc888fa1c0833816508d32
Author: Rayan Kanso <rayankans@chromium.org>
Date: Fri Jan 04 12:11:55 2019

[Background Fetch] Fix UpdateUI race condition.

The jobs were sometimes being erased before the icon was updated. The
delegate now notifies the clients after the new UI information has been
passed along.

This adds another internal Job State to the delegate to know when the
job was complete.

Bug: 917384

Change-Id: I00c599e298e342fbfafaaa9a39d5d7bcdc5cf7ba
Reviewed-on: https://chromium-review.googlesource.com/c/1388646
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619916}
[modify] https://crrev.com/30cd990cecc03b0e52cc888fa1c0833816508d32/chrome/browser/background_fetch/background_fetch_browsertest.cc
[modify] https://crrev.com/30cd990cecc03b0e52cc888fa1c0833816508d32/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/30cd990cecc03b0e52cc888fa1c0833816508d32/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/30cd990cecc03b0e52cc888fa1c0833816508d32/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/30cd990cecc03b0e52cc888fa1c0833816508d32/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/30cd990cecc03b0e52cc888fa1c0833816508d32/content/browser/background_fetch/background_fetch_delegate_proxy.h
[modify] https://crrev.com/30cd990cecc03b0e52cc888fa1c0833816508d32/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
[modify] https://crrev.com/30cd990cecc03b0e52cc888fa1c0833816508d32/content/browser/background_fetch/mock_background_fetch_delegate.cc
[modify] https://crrev.com/30cd990cecc03b0e52cc888fa1c0833816508d32/content/public/browser/background_fetch_delegate.h
[modify] https://crrev.com/30cd990cecc03b0e52cc888fa1c0833816508d32/content/shell/browser/web_test/web_test_background_fetch_delegate.cc

Labels: Merge-Request-72 OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
Owner: rayankans@chromium.org
Requesting merge into 72.

This is safe since it only affects Background Fetch code which is in origin trials.

Manually merged locally and tested the change: https://chromium-review.googlesource.com/c/chromium/src/+/1395992 
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 4

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: abdulsyed@chromium.org
Labels: -Merge-Review-72 Merge-Approved-72
Approving merge to M72 branch 3626 based on comment #2. Please merge ASAP so we can pick it up for this week beta release. Thank you.
Pls merge your change to M72 branch 3626 ASAP (latest by 12:00 PM PT, tomorrow, 12/08) so we can pick it up for this week beta release on Wednesday. Thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 7

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/964afb98f8792cf4f34388f48e61979ff5fb5340

commit 964afb98f8792cf4f34388f48e61979ff5fb5340
Author: Rayan Kanso <rayankans@chromium.org>
Date: Mon Jan 07 17:59:12 2019

[Background Fetch] Fix UpdateUI race condition.

The jobs were sometimes being erased before the icon was updated. The
delegate now notifies the clients after the new UI information has been
passed along.

This adds another internal Job State to the delegate to know when the
job was complete.

Bug: 917384

(cherry picked from commit 30cd990cecc03b0e52cc888fa1c0833816508d32)

Change-Id: I00c599e298e342fbfafaaa9a39d5d7bcdc5cf7ba
Reviewed-on: https://chromium-review.googlesource.com/c/1388646
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#619916}
Reviewed-on: https://chromium-review.googlesource.com/c/1395992
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#586}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/chrome/browser/background_fetch/background_fetch_browsertest.cc
[modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/browser/background_fetch/background_fetch_delegate_proxy.h
[modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
[modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/browser/background_fetch/mock_background_fetch_delegate.cc
[modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/public/browser/background_fetch_delegate.h

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/964afb98f8792cf4f34388f48e61979ff5fb5340

Commit: 964afb98f8792cf4f34388f48e61979ff5fb5340
Author: rayankans@chromium.org
Commiter: rayankans@chromium.org
Date: 2019-01-07 17:59:12 +0000 UTC

[Background Fetch] Fix UpdateUI race condition.

The jobs were sometimes being erased before the icon was updated. The
delegate now notifies the clients after the new UI information has been
passed along.

This adds another internal Job State to the delegate to know when the
job was complete.

Bug: 917384

(cherry picked from commit 30cd990cecc03b0e52cc888fa1c0833816508d32)

Change-Id: I00c599e298e342fbfafaaa9a39d5d7bcdc5cf7ba
Reviewed-on: https://chromium-review.googlesource.com/c/1388646
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#619916}
Reviewed-on: https://chromium-review.googlesource.com/c/1395992
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#586}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment