Background Fetch's UpdateUI not always updating icon |
|||||||
Issue descriptionThere is a race condition between clearing the job details and offline items asking for the visuals.
,
Jan 4
Requesting merge into 72. This is safe since it only affects Background Fetch code which is in origin trials. Manually merged locally and tested the change: https://chromium-review.googlesource.com/c/chromium/src/+/1395992
,
Jan 4
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 7
Approving merge to M72 branch 3626 based on comment #2. Please merge ASAP so we can pick it up for this week beta release. Thank you.
,
Jan 7
Pls merge your change to M72 branch 3626 ASAP (latest by 12:00 PM PT, tomorrow, 12/08) so we can pick it up for this week beta release on Wednesday. Thank you.
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/964afb98f8792cf4f34388f48e61979ff5fb5340 commit 964afb98f8792cf4f34388f48e61979ff5fb5340 Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Jan 07 17:59:12 2019 [Background Fetch] Fix UpdateUI race condition. The jobs were sometimes being erased before the icon was updated. The delegate now notifies the clients after the new UI information has been passed along. This adds another internal Job State to the delegate to know when the job was complete. Bug: 917384 (cherry picked from commit 30cd990cecc03b0e52cc888fa1c0833816508d32) Change-Id: I00c599e298e342fbfafaaa9a39d5d7bcdc5cf7ba Reviewed-on: https://chromium-review.googlesource.com/c/1388646 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#619916} Reviewed-on: https://chromium-review.googlesource.com/c/1395992 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#586} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/chrome/browser/background_fetch/background_fetch_delegate_impl.h [modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/browser/background_fetch/background_fetch_delegate_proxy.cc [modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/browser/background_fetch/background_fetch_delegate_proxy.h [modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc [modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/browser/background_fetch/mock_background_fetch_delegate.cc [modify] https://crrev.com/964afb98f8792cf4f34388f48e61979ff5fb5340/content/public/browser/background_fetch_delegate.h
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/964afb98f8792cf4f34388f48e61979ff5fb5340 Commit: 964afb98f8792cf4f34388f48e61979ff5fb5340 Author: rayankans@chromium.org Commiter: rayankans@chromium.org Date: 2019-01-07 17:59:12 +0000 UTC [Background Fetch] Fix UpdateUI race condition. The jobs were sometimes being erased before the icon was updated. The delegate now notifies the clients after the new UI information has been passed along. This adds another internal Job State to the delegate to know when the job was complete. Bug: 917384 (cherry picked from commit 30cd990cecc03b0e52cc888fa1c0833816508d32) Change-Id: I00c599e298e342fbfafaaa9a39d5d7bcdc5cf7ba Reviewed-on: https://chromium-review.googlesource.com/c/1388646 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#619916} Reviewed-on: https://chromium-review.googlesource.com/c/1395992 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#586} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jan 4