Background Fetch download progress bar resetting with every new request |
|||||||
Issue descriptionA Background Fetch can download multiple requests, the progress bar needs to incrementally progress rather than reset when a new download is started.
,
Dec 27
,
Dec 27
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 27
Thanks for landing this fix. Can you please comment on how safe this merge is? Is it verified in canary?
,
Dec 27
Yes, this is verified in canary. It's also safe, since it only affects Background Fetch code, which is launched as an origin trial.
,
Dec 27
Approved for M72. Branch: 3626
,
Dec 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a395dd4c190828485fb3afeb82544dca43877980 commit a395dd4c190828485fb3afeb82544dca43877980 Author: Rayan Kanso <rayankans@chromium.org> Date: Fri Dec 28 11:31:14 2018 [Background Fetch] Correctly report notfication progress value The progress value was being reset with every new fetch being processed. TBR=rayankans@chromium.org (cherry picked from commit 197b3f5659fba66c0bd539d7209b7b52abc09c56) Bug: 917382 Change-Id: Iaf353ea4a144d5cc5259f2601f5b7b4b490e5da7 Reviewed-on: https://chromium-review.googlesource.com/c/1388109 Reviewed-by: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618819} Reviewed-on: https://chromium-review.googlesource.com/c/1391884 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#526} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/a395dd4c190828485fb3afeb82544dca43877980/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/a395dd4c190828485fb3afeb82544dca43877980/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/a395dd4c190828485fb3afeb82544dca43877980/chrome/browser/background_fetch/background_fetch_delegate_impl.h
,
Dec 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a395dd4c190828485fb3afeb82544dca43877980 Commit: a395dd4c190828485fb3afeb82544dca43877980 Author: rayankans@chromium.org Commiter: rayankans@chromium.org Date: 2018-12-28 11:31:14 +0000 UTC [Background Fetch] Correctly report notfication progress value The progress value was being reset with every new fetch being processed. TBR=rayankans@chromium.org (cherry picked from commit 197b3f5659fba66c0bd539d7209b7b52abc09c56) Bug: 917382 Change-Id: Iaf353ea4a144d5cc5259f2601f5b7b4b490e5da7 Reviewed-on: https://chromium-review.googlesource.com/c/1388109 Reviewed-by: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#618819} Reviewed-on: https://chromium-review.googlesource.com/c/1391884 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#526} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7c5067f8e6ad50b0354c64061d2334b272fb0f5 commit b7c5067f8e6ad50b0354c64061d2334b272fb0f5 Author: Rayan Kanso <rayankans@chromium.org> Date: Fri Dec 28 13:01:06 2018 Revert "[Background Fetch] Correctly report notfication progress value" This reverts commit a395dd4c190828485fb3afeb82544dca43877980. Reason for revert: Broke the build Bug: 918132 Original change's description: > [Background Fetch] Correctly report notfication progress value > > The progress value was being reset with every new fetch being processed. > > TBR=rayankans@chromium.org > > (cherry picked from commit 197b3f5659fba66c0bd539d7209b7b52abc09c56) > > Bug: 917382 > Change-Id: Iaf353ea4a144d5cc5259f2601f5b7b4b490e5da7 > Reviewed-on: https://chromium-review.googlesource.com/c/1388109 > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#618819} > Reviewed-on: https://chromium-review.googlesource.com/c/1391884 > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > Cr-Commit-Position: refs/branch-heads/3626@{#526} > Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} TBR=nator@chromium.org,rayankans@chromium.org Change-Id: Idf7ca1fb721803d84a9025bcedcb78a7e653afcf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 917382 Reviewed-on: https://chromium-review.googlesource.com/c/1392090 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#527} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/b7c5067f8e6ad50b0354c64061d2334b272fb0f5/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/b7c5067f8e6ad50b0354c64061d2334b272fb0f5/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/b7c5067f8e6ad50b0354c64061d2334b272fb0f5/chrome/browser/background_fetch/background_fetch_delegate_impl.h
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5f83514ba290cbf0e2ca8333587b0fa68abab27 commit f5f83514ba290cbf0e2ca8333587b0fa68abab27 Author: Rayan Kanso <rayankans@chromium.org> Date: Wed Jan 02 12:23:37 2019 [Background Fetch] Correctly report notfication progress value The progress value was being reset with every new fetch being processed. TBR=rayankans@chromium.org (cherry picked from commit 197b3f5659fba66c0bd539d7209b7b52abc09c56) Bug: 917382 Change-Id: Ic639cb3fb1fa6affd2d34c7e230eef68a355d72f Reviewed-on: https://chromium-review.googlesource.com/c/1393265 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#536} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/f5f83514ba290cbf0e2ca8333587b0fa68abab27/chrome/browser/background_fetch/background_fetch_browsertest.cc [modify] https://crrev.com/f5f83514ba290cbf0e2ca8333587b0fa68abab27/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/f5f83514ba290cbf0e2ca8333587b0fa68abab27/chrome/browser/background_fetch/background_fetch_delegate_impl.h
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5f83514ba290cbf0e2ca8333587b0fa68abab27 Commit: f5f83514ba290cbf0e2ca8333587b0fa68abab27 Author: rayankans@chromium.org Commiter: rayankans@chromium.org Date: 2019-01-02 12:23:37 +0000 UTC [Background Fetch] Correctly report notfication progress value The progress value was being reset with every new fetch being processed. TBR=rayankans@chromium.org (cherry picked from commit 197b3f5659fba66c0bd539d7209b7b52abc09c56) Bug: 917382 Change-Id: Ic639cb3fb1fa6affd2d34c7e230eef68a355d72f Reviewed-on: https://chromium-review.googlesource.com/c/1393265 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#536} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 2
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Dec 24