New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 917379 link

Starred by 1 user
Status: Fixed
Owner:
michaelludwig@google.com
Closed: Dec 27
Cc:
█ bsalomon@chromium.org
fmalita@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Rebaseline tests for Skia rectangle perf update

Project Member Reported by michaelludwig@google.com, Dec 21 
The following layout tests:

* media/video-layer-crash.html
* virtual/gpu-rasterization/images/color-profile-background-image-cover.html
* virtual/gpu-rasterization/images/color-profile-background-image-space.html
* virtual/gpu-rasterization/images/cross-fade-background-size.html
* virtual/gpu-rasterization/images/feature-policy-oversized-images-styles.html
* virtual/gpu-rasterization/images/image-map-anchor-children.html
* virtual/gpu-rasterization/images/sprite-no-bleed.html
* virtual/gpu/fast/canvas/canvas-drawImage-antiAlias.html
* virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns.html
* virtual/gpu/fast/canvas/image-object-in-canvas.html
* virtual/video-surface-layer/media/video-layer-crash.html

must be updated for Skia CL: https://skia-review.googlesource.com/c/skia/+/179255/5

All images to be rebased are imperceptible pixel changes due to different texture interpolation / pixel boundaries.

This also blocks b/120946388
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b47468705c43bd1dd590e68cdcd67ab6f4d400e

commit 7b47468705c43bd1dd590e68cdcd67ab6f4d400e
Author: Michael Ludwig <michaelludwig@google.com>
Date: Fri Dec 21 15:56:46 2018

Suppress tests for Skia roll

Bug:  917379 
Change-Id: I67076b26342556c5860f475128a1db62feb64961
Reviewed-on: https://chromium-review.googlesource.com/c/1388546
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
Cr-Commit-Position: refs/heads/master@{#618540}
[modify] https://crrev.com/7b47468705c43bd1dd590e68cdcd67ab6f4d400e/third_party/blink/web_tests/TestExpectations

Comment 2 by michaelludwig@google.com, Dec 21

Blocking: -914833
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cb051db4a637bf58479d98247d9e5bb43fba41e

commit 1cb051db4a637bf58479d98247d9e5bb43fba41e
Author: Michael Ludwig <michaelludwig@google.com>
Date: Thu Dec 27 16:41:35 2018

Remove suppression for rebaseline

Bug:  917379 
Change-Id: I1d2ac914c191f770bcd62f7387a0f3b76599dccf
Reviewed-on: https://chromium-review.googlesource.com/c/1390957
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619044}
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/linux/media/video-layer-crash-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/linux/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/linux/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/linux/virtual/video-surface-layer/media/video-layer-crash-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/mac/media/video-layer-crash-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/feature-policy-oversized-images-styles-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/image-map-anchor-children-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/mac/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/mac/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/mac/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/win/media/video-layer-crash-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/win/virtual/gpu-rasterization/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/platform/win/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/1cb051db4a637bf58479d98247d9e5bb43fba41e/third_party/blink/web_tests/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png

Comment 4 by michaelludwig@google.com, Dec 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment