New issue
Advanced search Search tips

Issue 917378 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Fix broken ADMX on Chrome OS

Project Member Reported by ljusten@chromium.org, Dec 21

Issue description

Chrome OS ADMX fails to load since policy SAMLOfflineSigninTimeLimit has minimum of -1, which is not supported on Chrome OS.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90023011b90ad3da0ae23c5004a11598e7374a12

commit 90023011b90ad3da0ae23c5004a11598e7374a12
Author: Lutz Justen <ljusten@chromium.org>
Date: Fri Dec 21 15:37:22 2018

admx_writer: Don't write negative minValue/maxValue

These broke the ADMX templates on Chrome OS since the
SAMLOfflineSigninTimeLimit has a negative minimum, which is not allowed.
Just don't write minimum for now.

TBR=pastarmovj@chromium.org
BUG= chromium:917378 
TEST=components/policy/tools/template_writers/test_suite_all.py

Change-Id: Ib7617bf075c2e581a7b8b2e9debc2c34f9ff52f2
Reviewed-on: https://chromium-review.googlesource.com/c/1388491
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618531}
[modify] https://crrev.com/90023011b90ad3da0ae23c5004a11598e7374a12/components/policy/tools/template_writers/writers/admx_writer.py

Status: Fixed (was: Assigned)
Verify:
- chromeos.admx/adml files from this build should work in the GPO editor again
Hi ljusten,

Seeing the change, does this bug require any manual verification?


Yes, once this lands in Dev (check https://cros-updates-serving.appspot.com/ for 73.0.3648.0), download the policy_templates.zip file from here:
https://dl.google.com/chrome/policy/dev_policy_templates.zip

Alternatively, grab the file from a Canary build if you know how.

Extract the Chrome OS ADMX templates from that file and install them on a Windows server. Then check whether they're loading up fine in the GPO editor.

Hi Lutz, looks like the new ADMX templates already installed on chromeadm-lab.com (we don't have any other Windows server to check) and they're loading up fine in the GPO editor. Can we mark this as Verified?
Status: Verified (was: Fixed)
Yup, I needed them yesterday. I guess we can mark it as verified, even though I built them from my local checkout and not from an official build.

Sign in to add a comment