New issue
Advanced search Search tips

Issue 917377 link

Starred by 2 users
Status: Fixed
Owner:
perezju@chromium.org
Closed: Jan 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[soundwave] Add option on services.Request to retrieve json/jsonp format

Project Member Reported by perezju@chromium.org, Dec 21 
In particular, when expecting a json response, some services expect us to explicitly add 'Accept=application/json' to the header.

Furthermore, we can make it more transparent and easier to deal with jsonp ("padded") reponses with leading junk before the actual json content.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/d9f036200e10164c1e67f6d1a083a9ed750e41a7

commit d9f036200e10164c1e67f6d1a083a9ed750e41a7
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Jan 03 13:37:36 2019

[soundwave] Add services.Request(accept=..) option

Currently only 'json' option is implemented to parse the response
as a json object (stripping off the json security prefix if present).
The default is still to return the raw unparsed content.

Bug:  chromium:917377 
Change-Id: Ib4c8849ed27a423b018a57d9dee0a5db4a63cbca
Reviewed-on: https://chromium-review.googlesource.com/c/1387917
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>

[modify] https://crrev.com/d9f036200e10164c1e67f6d1a083a9ed750e41a7/experimental/soundwave/services/pinpoint_service_test.py
[modify] https://crrev.com/d9f036200e10164c1e67f6d1a083a9ed750e41a7/experimental/soundwave/services/dashboard_service_test.py
[modify] https://crrev.com/d9f036200e10164c1e67f6d1a083a9ed750e41a7/experimental/soundwave/services/pinpoint_service.py
[modify] https://crrev.com/d9f036200e10164c1e67f6d1a083a9ed750e41a7/experimental/soundwave/services/isolate_service.py
[modify] https://crrev.com/d9f036200e10164c1e67f6d1a083a9ed750e41a7/experimental/soundwave/services/isolate_service_test.py
[modify] https://crrev.com/d9f036200e10164c1e67f6d1a083a9ed750e41a7/experimental/soundwave/services/dashboard_service.py
[modify] https://crrev.com/d9f036200e10164c1e67f6d1a083a9ed750e41a7/experimental/soundwave/services/request.py
[modify] https://crrev.com/d9f036200e10164c1e67f6d1a083a9ed750e41a7/experimental/soundwave/services/request_test.py

Comment 2 by perezju@chromium.org, Jan 3

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cb6f15c4f4cfa346ae36ba6f81a00b843f71dc7

commit 3cb6f15c4f4cfa346ae36ba6f81a00b843f71dc7
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Jan 03 15:43:06 2019

Roll src/third_party/catapult 24bb5c49673b..d9f036200e10 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/24bb5c49673b..d9f036200e10


git log 24bb5c49673b..d9f036200e10 --date=short --no-merges --format='%ad %ae %s'
2019-01-03 perezju@chromium.org [soundwave] Add services.Request(accept=..) option


Created with:
  gclient setdep -r src/third_party/catapult@d9f036200e10

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:917377 
TBR=sullivan@chromium.org

Change-Id: I457430283fe4cf86809bf6ed7bf7931f8d7db876
Reviewed-on: https://chromium-review.googlesource.com/c/1394200
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619647}
[modify] https://crrev.com/3cb6f15c4f4cfa346ae36ba6f81a00b843f71dc7/DEPS
►

Sign in to add a comment