New issue
Advanced search Search tips

Issue 917376 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[soundwave] services.Request raises UnicodeDecodeError on non-json error responses

Project Member Reported by perezju@chromium.org, Dec 21

Issue description

e.g.:

  UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 26: ordinal not in range(128)

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/35caab8b839f1e5d3713ff6ed84fbc1b3b4a1970

commit 35caab8b839f1e5d3713ff6ed84fbc1b3b4a1970
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Jan 03 14:17:26 2019

[cli services] Fix encoding issue on non-json error responses

A previous CL fixed encoding problems the the content of an error
reponse (in json) included special characters.

That did not fix, however, the case when the error response is not
json but, e.g., plain text or html.

Bug:  chromium:917376 
Change-Id: I885390ebe35b0880c429c84640b3671e90f64a24
Reviewed-on: https://chromium-review.googlesource.com/c/1387916
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>

[modify] https://crrev.com/35caab8b839f1e5d3713ff6ed84fbc1b3b4a1970/experimental/soundwave/services/request.py
[modify] https://crrev.com/35caab8b839f1e5d3713ff6ed84fbc1b3b4a1970/experimental/soundwave/services/request_test.py

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ad7228845ec6f72c8a0526bb9950ba9e0cbb889

commit 7ad7228845ec6f72c8a0526bb9950ba9e0cbb889
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Jan 03 17:42:31 2019

Roll src/third_party/catapult d9f036200e10..35caab8b839f (1 commits)

https://chromium.googlesource.com/catapult.git/+log/d9f036200e10..35caab8b839f


git log d9f036200e10..35caab8b839f --date=short --no-merges --format='%ad %ae %s'
2019-01-03 perezju@chromium.org [cli services] Fix encoding issue on non-json error responses


Created with:
  gclient setdep -r src/third_party/catapult@35caab8b839f

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:917376 
TBR=sullivan@chromium.org

Change-Id: I1ff55149492fb34eda4d3607ad2e1ede731b07d1
Reviewed-on: https://chromium-review.googlesource.com/c/1394202
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619680}
[modify] https://crrev.com/7ad7228845ec6f72c8a0526bb9950ba9e0cbb889/DEPS

Sign in to add a comment