New issue
Advanced search Search tips

Issue 917374 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jan 8
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Unified: Inline settings affect each other

Project Member Reported by knollr@chromium.org, Dec 21 
Chrome Version: 73.0.3647.0
OS: ChromeOS

What steps will reproduce the problem?
(1) open tests.peter.sh/notification-generator/ and display two notifications
(2) open uber tray
(3) click the gear icon (settings) on both notifications in the unified message center

What is the expected result?
I should be able to select settings for the notifications independent of each other.


What happens instead?
Only one notification setting is selected, it acts as one big radio selection.
settings.gif
64.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ce9f46cbf3d593b6e71de0c1b1fe906c203f435

commit 5ce9f46cbf3d593b6e71de0c1b1fe906c203f435
Author: Richard Knoll <knollr@chromium.org>
Date: Tue Jan 08 11:41:51 2019

fix: only look for other RadioButtons under the same parent

RadioButton used to iterate through all views in the same window to
look for other buttons with the same group. This requires unique groups
across the whole window and makes it quite difficult to use multiple
components with radio buttons.

This changes the behavior so that RadioButton only looks for other
buttons that are below its parent().

Bug:  917374 
Change-Id: I30776fd9dfd90f51caefd8d64b77edcf0841bb2b
Reviewed-on: https://chromium-review.googlesource.com/c/1388154
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620684}
[modify] https://crrev.com/5ce9f46cbf3d593b6e71de0c1b1fe906c203f435/ui/views/controls/button/radio_button.cc
[modify] https://crrev.com/5ce9f46cbf3d593b6e71de0c1b1fe906c203f435/ui/views/controls/button/radio_button.h

Comment 2 by knollr@google.com, Jan 8

Status: Fixed (was: Untriaged)
►

Sign in to add a comment