New issue
Advanced search Search tips

Issue 917357 link

Starred by 2 users
Status: Verified
Owner:
manojgupta@chromium.org
Closed: Jan 13
Cc:
llozano@chromium.org
bpastene@chromium.org
vapier@chromium.org
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain

Blocked on:
issue 921048


Sign in to add a comment

cros compiler does not yet have clang r348515

Project Member Reported by thakis@chromium.org, Dec 21 
I taught clang -cc1as the flag -fdebug-compilation-dir in clang r348515. When I tried to use it in https://chromium-review.googlesource.com/c/chromium/src/+/1388544/1 the cros bots failed. (We only pass it if is_linux, but that's true for the host part of a cros build.)

I'll add a target_os != "chromeos" check to work around it. Filing this bug so we don't forget to remove that again once chromeos clang rolls past r348515.

Comment 1 by bpastene@chromium.org, Dec 21

Components: Infra>Client>ChromeOS>Build
The simplechrome bots (the cros bots that failed that cl) fetch the clang that the OS toolchain uses. I believe that's built and uploaded via https://cs.corp.google.com/chromeos_public/src/third_party/chromiumos-overlay/sys-devel/llvm/

Looks like it's on r339409 atm.

Comment 2 by bpastene@chromium.org, Dec 21

Cc: vapier@chromium.org steve...@chromium.org

Comment 3 by vapier@chromium.org, Dec 21

Components: -Build -Infra>Client>ChromeOS>Build Tools>ChromeOS-Toolchain
doesn't look like a build issue.  the llvm/clang used in chromium itself is never used when building CrOS.  if you want the CrOS compiler to roll something, please sync with the CrOS toolchain team.

Comment 4 by thakis@chromium.org, Dec 21 

That's what this bug attempts to do.

Comment 5 by vapier@chromium.org, Dec 21 

my point was about Component selection

Comment 6 by manojgupta@chromium.org, Dec 21 

thakis@ Do you just need r348515? I can cherry-pick it to the current Chrome OS llvm if that is the case.

Comment 7 by thakis@chromium.org, Dec 21 

There's no rush. Just ping this bug once your clang is past r348515 and then I'll remove a workaround on the chrome side.

Comment 9 by steve...@chromium.org, Dec 21 

vapier@, isn't this blocked on issue 913317?

i.e. Simple Chrome is still using the CrOS SDK from 11361.0.0, so any changes that affect the Simple Chrome builders requiring a vaguely recent CrOS toolchain are blocked until that is resolved :(

Comment 10 by lloz...@google.com, Dec 21

Labels: -Pri-3 Pri-2
Owner: manojgupta@chromium.org
Status: Assigned (was: Untriaged)
I agree with #7. 
Assigning to Manoj who is the current "mage" for the next compiler roll. 
Will notify thakis when the roll is done.

Comment 11 by manojgupta@chromium.org, Jan 10

Owner: thakis@chromium.org
thakis@ I have updated Chrome OS clang to r349610. Please check.

Comment 12 by thakis@chromium.org, Jan 11

Blockedon: 921048
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49d806559ba21fd1348e9cf7860c3fd2365a36fa

commit 49d806559ba21fd1348e9cf7860c3fd2365a36fa
Author: Nico Weber <thakis@chromium.org>
Date: Sun Jan 13 01:51:12 2019

cros: Pass -Wa,-fdebug-compilation-dir,. now that cros's clang understands it.

Bug:  917357 
Change-Id: I6a0039a8357150f7b5e6c27f486bac8736ce4577
Reviewed-on: https://chromium-review.googlesource.com/c/1405281
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622329}
[modify] https://crrev.com/49d806559ba21fd1348e9cf7860c3fd2365a36fa/build/config/compiler/BUILD.gn

Comment 14 by thakis@chromium.org, Jan 13

Owner: manojgupta@chromium.org
Status: Fixed (was: Assigned)
Thanks!

Comment 15 by lloz...@google.com, Jan 14 

Thanks Nico.

Comment 16 by manojgupta@chromium.org, Jan 14

Status: Verified (was: Fixed)
►

Sign in to add a comment