Issue metadata
Sign in to add a comment
|
White patch is seen when you navigate to View offline version in New Tab in Reading list |
||||||||||||||||||||||
Issue descriptionApp Version:72.0.3626.31 iOS Version: 11.4.1 only Device: iPhone 5s, iPhone 7, iPad Pro URL: Steps to reproduce: 1. Launch Chrome 2. Navigate to any article --> Add it to read later 3. Navigate to the reading list --> Long tap on the article --> tap on View offline version in New Tab 4. Observe Observed results: White patch is seen when you navigate to View offline version in New Tab in Reading list Expected results: White patch should not be seen when you navigate to View offline version in New Tab in Reading list Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Observed behavior in Chrome Mobile on Android: No Check for similar behavior on Firefox/Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on 71.0.3578.89, iOS Version- 11.4.1 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on 72.0.3626.31, iOS Version- 11.4.1 Regression? Yes Good Build: 72.0.3591.0 Rev: 148434e1b31c Bad build: 72.0.3592.0 Rev: 3274d2b27158
,
Dec 21
It may be related to fullscreen.
,
Dec 27
,
Dec 27
The issue doesn't reproduce on M73, it was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1356588. But the fix introduced issue 917993 .
,
Jan 4
,
Jan 7
Kurt: I am leaving for a week. Could you take care of fixing this bug? Please take the most reasonable solution between https://chromium-review.googlesource.com/c/chromium/src/+/1392947 and https://chromium-review.googlesource.com/c/chromium/src/+/1391669 (you can check with Eugene).
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e67ec182d16c4d4619ff941a7e71a93e3d07cff commit 9e67ec182d16c4d4619ff941a7e71a93e3d07cff Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Jan 10 02:32:41 2019 [iOS] Reset the FullscreenModel when a WebState is shown. This is a later signal than the WebStateList change, and catches updates to the toolbar heights that may have occurred while displaying the new WebState. Bug: 917341 Change-Id: If26dd861ab7d3bb6fc2ebab2e319f6e80a96f565 Reviewed-on: https://chromium-review.googlesource.com/c/1404421 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#621428} [modify] https://crrev.com/9e67ec182d16c4d4619ff941a7e71a93e3d07cff/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.h [modify] https://crrev.com/9e67ec182d16c4d4619ff941a7e71a93e3d07cff/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.mm
,
Jan 10
,
Jan 10
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. The owner of this bug should confirm if a merge is required here. If so, add Merge-Request-72 label and indicate which commits/CLs are to be merged. Otherwise, remove Merge-TBD label. Thanks.
,
Jan 10
,
Jan 10
This bug requires manual review: Less than 15 days to go before AppStore submit on M72 Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 11
Verified the issue on latest chrome canary version 73.0.3668.0 on iPhone X, iPhone 8 with iOS 11.4.1, following the steps mentioned in comment #0. White patch is not seen when navigated to offline version of reading list article. Looks good.
,
Jan 11
Approved, please merge asap.
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4aa678dd65400539dc2c2615906c953e39af1ec7 commit 4aa678dd65400539dc2c2615906c953e39af1ec7 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Fri Jan 11 18:17:08 2019 [iOS] Reset the FullscreenModel when a WebState is shown. This is a later signal than the WebStateList change, and catches updates to the toolbar heights that may have occurred while displaying the new WebState. Bug: 917341 Change-Id: If26dd861ab7d3bb6fc2ebab2e319f6e80a96f565 Reviewed-on: https://chromium-review.googlesource.com/c/1404421 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#621428}(cherry picked from commit 9e67ec182d16c4d4619ff941a7e71a93e3d07cff) Reviewed-on: https://chromium-review.googlesource.com/c/1407368 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#645} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/4aa678dd65400539dc2c2615906c953e39af1ec7/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.h [modify] https://crrev.com/4aa678dd65400539dc2c2615906c953e39af1ec7/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.mm
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4aa678dd65400539dc2c2615906c953e39af1ec7 Commit: 4aa678dd65400539dc2c2615906c953e39af1ec7 Author: kkhorimoto@chromium.org Commiter: kkhorimoto@chromium.org Date: 2019-01-11 18:17:08 +0000 UTC [iOS] Reset the FullscreenModel when a WebState is shown. This is a later signal than the WebStateList change, and catches updates to the toolbar heights that may have occurred while displaying the new WebState. Bug: 917341 Change-Id: If26dd861ab7d3bb6fc2ebab2e319f6e80a96f565 Reviewed-on: https://chromium-review.googlesource.com/c/1404421 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#621428}(cherry picked from commit 9e67ec182d16c4d4619ff941a7e71a93e3d07cff) Reviewed-on: https://chromium-review.googlesource.com/c/1407368 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#645} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 16
(6 days ago)
Verified on chrome beta version 72.0.3626.59 on iPhone 8 plus, iPad Pro with iOS 11.4.1, following the steps mentioned in comment #0. White patch is not seen when navigated to offline version of reading list article. Looks good. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vbarig...@chromium.org
, Dec 21