Beta still reference Autofill internal repo |
||||
Issue descriptionAfter https://bugs.chromium.org/p/chromium/issues/detail?id=888640, it seems that repo has been deleted, but beta build spec still reference it https://chrome-internal.googlesource.com/chrome/tools/buildspec.git/+/0c43e437c976bee6f2d6a18144845566d8bc9f9d/build/chrome-official-ios/DEPS#196 Today official build still works due to cache, but locally I cannot build. I am not sure if this will autofix in next buildspec, but filing blocking bug to take a look before holiday break.
,
Dec 21
I have restored the repo. Maybe it is a good idea to keep it around, so as to not break historical builds.
,
Dec 21
Could we set a NextAction date?
,
Dec 21
I don't know how long we want historical builds to work. Maybe a couple of releases?
,
Jan 7
Is there still an issue here? What do you mean by historical build?
,
Jan 7
What I mean is, if people want to build an old release where that repo is referenced, they wouldn't be able to if we delete the repo. So I was wondering if we care about people being able to build old releases.
,
Jan 7
Note that "people" is really "googlers" as it is a src-internal repo. Chromium would continue to build correctly. But the question is for all platforms.
,
Jan 7
I'm closed this as fixed. Official builds work now, and I don't see a good reason to delete the repo.
,
Jan 7
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. The owner of this bug should confirm if a merge is required here. If so, add Merge-Request-72 label and indicate which commits/CLs are to be merged. Otherwise, remove Merge-TBD label. Thanks.
,
Jan 7
No merge needed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by se...@chromium.org
, Dec 21