Project Paradise - if cards save fail, the card icon should be changed |
|||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win10, MacOS 10.12, etc...) What steps will reproduce the problem? (1)save cards (2)animation in the omnibox (3)save failed What is the expected result? should have a warning icon letting users know that their cards save failed What happens instead? No icon change Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3c3363422091ed0d9c37deb267157733da559e1 commit b3c3363422091ed0d9c37deb267157733da559e1 Author: Jason Guo <jiahuiguo@chromium.org> Date: Fri Jan 11 23:25:09 2019 Show credit card error icon when some cards save fails, instead of showing the same card icon. Bug: 917288 Change-Id: I869e5edc3f668afbcc0f5309839ab37317336eac Reviewed-on: https://chromium-review.googlesource.com/c/1385451 Commit-Queue: Jason Guo <jiahuiguo@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#622214} [modify] https://crrev.com/b3c3363422091ed0d9c37deb267157733da559e1/chrome/browser/ui/autofill/manage_migration_ui_controller.cc [modify] https://crrev.com/b3c3363422091ed0d9c37deb267157733da559e1/chrome/browser/ui/autofill/manage_migration_ui_controller.h [modify] https://crrev.com/b3c3363422091ed0d9c37deb267157733da559e1/chrome/browser/ui/views/autofill/local_card_migration_icon_view.cc [modify] https://crrev.com/b3c3363422091ed0d9c37deb267157733da559e1/chrome/browser/ui/views/autofill/local_card_migration_icon_view.h [modify] https://crrev.com/b3c3363422091ed0d9c37deb267157733da559e1/chrome/browser/ui/views/page_action/page_action_icon_view.cc [modify] https://crrev.com/b3c3363422091ed0d9c37deb267157733da559e1/chrome/browser/ui/views/page_action/page_action_icon_view.h
,
Jan 13
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rfeng@chromium.org
, Dec 21