New issue
Advanced search Search tips

Issue 917286 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

SignedExchange: certificate request should have Accept: application/cert-chain+cbor header

Project Member Reported by ksakamoto@chromium.org, Dec 21

Issue description

https://wicg.github.io/webpackage/loading.html#handling-cert-url

Currently SignedExchangeCertFetcher does check response's content-type, but doesn't set Accept: request header.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7327e87dd40ca5c8ef7d92c201c88cbb742c898

commit b7327e87dd40ca5c8ef7d92c201c88cbb742c898
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed Jan 09 06:02:12 2019

SignedExchange: Set Accept header in certificate requests

SignedExchange certificate requests should have
Accept: application/cert-chain+cbor header.

Bug:  917286 
Change-Id: Ibf24b17d7074c45d46c391469379367b8b13bb83
Reviewed-on: https://chromium-review.googlesource.com/c/1399697
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621057}
[modify] https://crrev.com/b7327e87dd40ca5c8ef7d92c201c88cbb742c898/content/browser/web_package/signed_exchange_cert_fetcher.cc
[modify] https://crrev.com/b7327e87dd40ca5c8ef7d92c201c88cbb742c898/content/browser/web_package/signed_exchange_cert_fetcher_unittest.cc
[add] https://crrev.com/b7327e87dd40ca5c8ef7d92c201c88cbb742c898/third_party/blink/web_tests/external/wpt/signed-exchange/check-cert-request.tentative.html
[add] https://crrev.com/b7327e87dd40ca5c8ef7d92c201c88cbb742c898/third_party/blink/web_tests/external/wpt/signed-exchange/resources/check-cert-request.py
[add] https://crrev.com/b7327e87dd40ca5c8ef7d92c201c88cbb742c898/third_party/blink/web_tests/external/wpt/signed-exchange/resources/check-cert-request.sxg
[add] https://crrev.com/b7327e87dd40ca5c8ef7d92c201c88cbb742c898/third_party/blink/web_tests/external/wpt/signed-exchange/resources/check-cert-request.sxg.headers
[modify] https://crrev.com/b7327e87dd40ca5c8ef7d92c201c88cbb742c898/third_party/blink/web_tests/external/wpt/signed-exchange/resources/generate-test-sxgs.sh

Status: Fixed (was: Assigned)

Sign in to add a comment