New issue
Advanced search Search tips

Issue 917284 link

Starred by 3 users
Status: Fixed
Owner:
kinuko@chromium.org
Closed: Jan 14
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clarify the behavior of AppCache with ServiceWorker when claim() is called

Project Member Reported by kinuko@chromium.org, Dec 21 
Expectation is that AppCache should be ignored once SW is in place.

Currently this seems broken when Network Service is not enabled (but fixing the legacy code case would be probably very low-priority).
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcd3934d054727fb44d5676f40e6b35ea52e0005

commit bcd3934d054727fb44d5676f40e6b35ea52e0005
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Thu Dec 27 10:54:38 2018

Add a test for ServiceWorker and AppCache interaction with claim()

Bug:  917284 
Change-Id: I953dfecdf1ae825343ae659d496d089ce356e662
Reviewed-on: https://chromium-review.googlesource.com/c/1388129
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619022}
[modify] https://crrev.com/bcd3934d054727fb44d5676f40e6b35ea52e0005/content/renderer/loader/child_url_loader_factory_bundle.h
[modify] https://crrev.com/bcd3934d054727fb44d5676f40e6b35ea52e0005/third_party/blink/web_tests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/bcd3934d054727fb44d5676f40e6b35ea52e0005/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/bcd3934d054727fb44d5676f40e6b35ea52e0005/third_party/blink/web_tests/external/wpt/service-workers/service-worker/appcache-ordering-main.https.html
[add] https://crrev.com/bcd3934d054727fb44d5676f40e6b35ea52e0005/third_party/blink/web_tests/external/wpt/service-workers/service-worker/claim-fetch-with-appcache.https.html
[modify] https://crrev.com/bcd3934d054727fb44d5676f40e6b35ea52e0005/third_party/blink/web_tests/external/wpt/service-workers/service-worker/resources/appcache-ordering.manifest
[modify] https://crrev.com/bcd3934d054727fb44d5676f40e6b35ea52e0005/third_party/blink/web_tests/external/wpt/service-workers/service-worker/resources/claim-worker.js
[modify] https://crrev.com/bcd3934d054727fb44d5676f40e6b35ea52e0005/third_party/blink/web_tests/external/wpt/service-workers/service-worker/resources/test-helpers.sub.js

Comment 2 by falken@chromium.org, Jan 14

Status: Fixed (was: Assigned)
Assuming it's ok to mark fixed.
►

Sign in to add a comment