Some video tests load huge raw video into memory, causing out of memory |
||
Issue descriptionhiroh@ reported video tests are failing recently for some unknown reason. For example: https://stainless.corp.google.com/search?exclude_retried=true&first_date=2018-11-24&master_builder_name=master-release&builder_name_number=&shard=&exclude_acts=true&builder_name=&master_builder_name_number=&owner=&retry=&exclude_cts=false&exclude_non_production=false&hostname=&board=&branch=master&test=%5Etast%5C.video%5C.EncodeAccelH264720PI420%24&suite=&build=%5ER73%5C-11364%5C.0%5C.0%24&status=FAIL&status=ERROR&status=ABORT&reason=&waterfall=&exclude_not_run=false&last_date=2018-12-21&exclude_non_release=true&exclude_au=true&model=&view=list It looks like some video tests load decoded raw video into memory after this change. https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1344717/3/src/chromiumos/tast/local/bundles/cros/video/encode/yuv.go But, for example, video.EncodeAccelH264720PI420 decodes tulip2-1280x720_20181120.vp9.webm, and its result is 660MB. $ gsutil cp gs://chromiumos-test-assets-public/tast/cros/video/tulip2-1280x720_20181120.vp9.webm ./ $ vpxdec tulip2-1280x720_20181120.vp9.webm --codec=vp9 --i420 -o tulip2-1280x720_20181120.vp9.yuv $ ls -lh tulip2-1280x720_20181120* -rw-r--r-- 1 nya primarygroup 522K Dec 21 13:38 tulip2-1280x720_20181120.vp9.webm -rw-r--r-- 1 nya primarygroup 660M Dec 21 13:47 tulip2-1280x720_20181120.vp9.yuv
,
Dec 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/57a2a3e8e5f1dfcca4f50399bb619e6ee06bd5bc commit 57a2a3e8e5f1dfcca4f50399bb619e6ee06bd5bc Author: Shuhei Takahashi <nya@chromium.org> Date: Fri Dec 28 08:43:13 2018 video: Avoid reading vpxdec output into memory. vpxdec output for some tests (such as video.EncodeAccelH264720PI420) will be as large as hundreds of megabytes. BUG= chromium:917282 TEST=tast run nocturne video.EncodeAccelH264720PI420 # and see cros process does not consume too much memory Change-Id: Ibdec32715e3db194151e6f48b823af668a632695 Reviewed-on: https://chromium-review.googlesource.com/1388089 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/57a2a3e8e5f1dfcca4f50399bb619e6ee06bd5bc/src/chromiumos/tast/local/bundles/cros/video/encode/yuv.go
,
Jan 7
OOM errors look gone, though there are still failures. |
||
►
Sign in to add a comment |
||
Comment 1 by nya@chromium.org
, Dec 21