New issue
Advanced search Search tips

Issue 917273 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Catapult viewer fails to load netlog

Reported by amistryt...@gmail.com, Dec 21

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 11427.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3647.0 Safari/537.36
Platform: 11427.0.0 (Official Build) dev-channel chell test

Example URL:

Steps to reproduce the problem:
1. Open about://net-export and capture a netlog.
2. Go to https://netlog-viewer.appspot.com/ and load the netlog file

What is the expected behavior?
Able to view the netlog.

What went wrong?
Load failed:

Invalid constants object.

Did this work before? N/A 

Chrome version: 73.0.3647.0  Channel: n/a
OS Version: 11427.0.0
Flash Version:
 
Cc: amistry@chromium.org
Components: -Internals>Network
Components: Internals>Network>Logging
Owner: eroman@chromium.org
Status: Assigned (was: Unconfirmed)
[+eroman]:  I'm guessing this was due to https://chromium.googlesource.com/chromium/src/+/aefc98c4a52b9af51cfc761abbc2bbcb6a0d75e0?
Status: Started (was: Assigned)
Yes this is broken my my change(s).
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/0ac90e47d7321d9b83619f4d866a70fff99e9f36

commit 0ac90e47d7321d9b83619f4d866a70fff99e9f36
Author: Eric Roman <eroman@chromium.org>
Date: Mon Jan 14 20:18:52 2019

Fix import of new NetExport generated logs.

The time tick offset is now (usually) encoded as a number rather than a string.

Bug:  chromium:917273 
Change-Id: Iaecfa9b7be2a3bbea8d530a538c96e6be7515abd
Reviewed-on: https://chromium-review.googlesource.com/c/1390703
Commit-Queue: Eric Roman <eroman@chromium.org>
Auto-Submit: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>

[modify] https://crrev.com/0ac90e47d7321d9b83619f4d866a70fff99e9f36/netlog_viewer/netlog_viewer/log_view_painter_test.html
[modify] https://crrev.com/0ac90e47d7321d9b83619f4d866a70fff99e9f36/netlog_viewer/netlog_viewer/timeline_view_test.js
[modify] https://crrev.com/0ac90e47d7321d9b83619f4d866a70fff99e9f36/netlog_viewer/netlog_viewer/main.js

Status: Fixed (was: Started)
(Also pushed an updated version of netlog viewer)
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9d39cb7402e371e19d1485f07270953c266d4cd

commit c9d39cb7402e371e19d1485f07270953c266d4cd
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Jan 16 02:43:37 2019

Roll src/third_party/catapult 96320b515106..78448d90081e (17 commits)

https://chromium.googlesource.com/catapult.git/+log/96320b515106..78448d90081e


git log 96320b515106..78448d90081e --date=short --no-merges --format='%ad %ae %s'
2019-01-15 vollick@chromium.org Plumb the trace buffer size for atrace
2019-01-15 perezju@chromium.org Revert "[py_utils] Add modules_util.RequireVersion"
2019-01-15 taylori@google.com Fix handling of perfetto protobuf on mac
2019-01-15 perezju@chromium.org [dashboard] Remove dead code in start_try_job.py
2019-01-15 perezju@chromium.org Revert "Remove TagMap."
2019-01-15 perezju@chromium.org [Telemetry] Add list_of_scalar_values.mean
2019-01-15 dtu@chromium.org [pinpoint] Add Tags field to try job dialog.
2019-01-15 dtu@chromium.org [pinpoint] Ignore cached isolate hashes over 8 weeks old.
2019-01-14 eroman@chromium.org Fix import of new NetExport generated logs.
2019-01-14 bsheedy@chromium.org Fix gtest conversion multiplier
2019-01-14 eyaich@google.com Adding timeToFirstViewportReady metric
2019-01-14 perezju@chromium.org [py_utils] Add modules_util.RequireVersion
2019-01-14 perezju@chromium.org Remove GetNetworkData methods
2019-01-14 perezju@chromium.org [cli services] Add buildbucket_service
2019-01-14 perezju@chromium.org [Telemetry] Remove TBMv1 metrics.SmoothnessMetric
2019-01-11 benjhayden@chromium.org Remove TagMap.
2019-01-11 benjhayden@chromium.org Truncate serialized floats in HistogramSet JSON.


Created with:
  gclient setdep -r src/third_party/catapult@78448d90081e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:776709,chromium:777865,chromium:918218,chromium:921616,chromium:874940,chromium:916877, chromium:917273 ,chromium:921342,chromium:904879,chromium:776709,chromium:777865,chromium:480512, chromium:919093 , chromium:691581 ,chromium:921000,chromium:918218,chromium:918208
TBR=sullivan@chromium.org

Change-Id: I75c07d8719f5668f9b4a95a9757cf6c25412b547
Reviewed-on: https://chromium-review.googlesource.com/c/1413252
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623062}
[modify] https://crrev.com/c9d39cb7402e371e19d1485f07270953c266d4cd/DEPS

Sign in to add a comment