New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 917188 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 901910



Sign in to add a comment

[Findit] Flake Analyzer - Update monorail bugs from auto action layer

Project Member Reported by lijeffrey@chromium.org, Dec 20

Issue description

Also deprecate UpdateFlakeBugPipeline
 
Blocking: 901910
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 26

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e6161b1a48ef4a9550490349d8c6ed43e293de59

commit e6161b1a48ef4a9550490349d8c6ed43e293de59
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Wed Dec 26 23:14:12 2018

[Findit] Flake Analyzer - Moving config to action_settings

1. Deprecate config for updating bugs vs cr, as they are the same. Renamed
   to the more general GetMinimumConfidenceToUpdateEndpoints() instead.
2. Introduce minimum_confidence_to_revert_flake_culprit, though not used yet.
2. Moved confidence scores to action_settings instead of check_flake_settings.

No other functional changes otherwise.


Bug: 917188
Change-Id: I06c0b2b6b1c0bc2a4efb4cad93ea0fff692c71ef
Reviewed-on: https://chromium-review.googlesource.com/c/1389286
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19723}
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/services/flake_failure/culprit_util.py
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/services/flake_failure/flake_bug_util.py
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/services/flake_failure/confidence_score_util.py
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/services/flake_failure/test/culprit_util_test.py
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/waterfall/test/wf_testcase.py
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/handlers/config.py
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/services/flake_failure/test/flake_bug_util_test.py
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/handlers/flake/detection/flake_detection_utils.py
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/model/wf_config.py
[modify] https://crrev.com/e6161b1a48ef4a9550490349d8c6ed43e293de59/appengine/findit/services/flake_failure/flake_constants.py

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ad8c1b5df39349f76027bd3f4576efefec86451b

commit ad8c1b5df39349f76027bd3f4576efefec86451b
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Fri Dec 28 23:18:01 2018

[Findit] Flake Analyzer - Update bug in auto action layer

UpdateFlakeBugPipeline has been deprecated. Instead, update monorail bugs
through auto action layer.

1. Don't comment on bugs if the daily limit of bug updates has been reached,
   measured by FlakeIssue's last_updated_timestamp_bu_flake_detection. This
   will cause bug updates between FA and FD to be shared.
2. Don't update if there are already comments by Findit on the bug, excluding
   the original comment (e.g. if Findit was the author).
3. Don't take any auto actions if not at least 0.7 confidence. Note this still
   needs to be refactored slightly (to be addressed in a separate CL) for where
   this value is read.

Bug: 917188
Change-Id: I1223639356d08492c66a71d87e3834492224029f
Reviewed-on: https://chromium-review.googlesource.com/c/1388009
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19737}
[modify] https://crrev.com/ad8c1b5df39349f76027bd3f4576efefec86451b/appengine/findit/services/test/monorail_util_test.py
[modify] https://crrev.com/ad8c1b5df39349f76027bd3f4576efefec86451b/appengine/findit/services/test/flake_issue_util_test.py
[modify] https://crrev.com/ad8c1b5df39349f76027bd3f4576efefec86451b/appengine/findit/services/actions/flake_analysis_actions.py
[modify] https://crrev.com/ad8c1b5df39349f76027bd3f4576efefec86451b/appengine/findit/services/actions/test/flake_analysis_actions_test.py
[modify] https://crrev.com/ad8c1b5df39349f76027bd3f4576efefec86451b/appengine/findit/services/monorail_util.py
[modify] https://crrev.com/ad8c1b5df39349f76027bd3f4576efefec86451b/appengine/findit/model/flake/flake_issue.py
[modify] https://crrev.com/ad8c1b5df39349f76027bd3f4576efefec86451b/appengine/findit/index.yaml
[modify] https://crrev.com/ad8c1b5df39349f76027bd3f4576efefec86451b/appengine/findit/services/flake_issue_util.py
[modify] https://crrev.com/ad8c1b5df39349f76027bd3f4576efefec86451b/appengine/findit/handlers/flake/detection/test/show_flake_test.py
[modify] https://crrev.com/ad8c1b5df39349f76027bd3f4576efefec86451b/appengine/findit/handlers/flake/detection/test/flake_detection_utils_test.py

Sign in to add a comment